Review main Merged

82161[TASK] Remove layout from subtypes_excludelist in indexedsearch_pi2

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 12/19/23, 07:31

Commit message

It is unclear why `layout` was excluded for the indexed search plugin.
In contrary to `pages` and `recursive` this field has no functionality
for extbase plugin.

In preparation for eventual deprecation of plugins of type list, this
exclusion is removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Nikita Hovratov uploaded patch set 1 12/09/23, 20:27

  2. core-ci voted on patch set 1 V +1 12/09/23, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50536

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 12/13/23, 10:30

  4. Oliver Klee voted on patch set 1 CR +1 V +1 12/13/23, 12:58

  5. Oli Bartsch commented on patch set 1 12/13/23, 14:56

    I don't quite understand the patch tbh. Removing "layout" from the excludelist leads to the field being displayed in the "Appearance" tab. Without the patch, the field is not displayed. The fact that the field is in a palette should not influence this behaviour.
  6. Nikita Hovratov commented on patch set 1 12/13/23, 16:19

    Reply

    Huh, you are right. Anyway, I wonder why layout is excluded at all. It has no functionality. `pages` and `recursive` are extbase specific. So, I would still remove it at least in main. Eventually we want to get rid of `subtypes_excludelist`.
  7. Nikita Hovratov uploaded patch set 2 CR +1 V +1 12/13/23, 16:25

  8. core-ci voted on patch set 2 V +1 12/13/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50626

  9. Oli Bartsch voted on patch set 2 CR +1 V +1 12/18/23, 16:49

  10. Stefan Bürk voted on patch set 2 CR +1 V +1 12/19/23, 05:11

  11. Oli Bartsch voted on patch set 2 CR +2 V +2 12/19/23, 07:31

  12. Oli Bartsch merged patch set 3 12/19/23, 07:31