82161[TASK] Remove layout from subtypes_excludelist in indexedsearch_pi2
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Nikita Hovratov uploaded patch set 1 12/09/23, 20:27
-
core-ci voted on patch set 1 V +1 12/09/23, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50536
-
Garvin Hicking voted on patch set 1 CR +1 V +1 12/13/23, 10:30
-
Oliver Klee voted on patch set 1 CR +1 V +1 12/13/23, 12:58
-
Oli Bartsch commented on patch set 1 12/13/23, 14:56
I don't quite understand the patch tbh. Removing "layout" from the excludelist leads to the field being displayed in the "Appearance" tab. Without the patch, the field is not displayed. The fact that the field is in a palette should not influence this behaviour. -
Nikita Hovratov commented on patch set 1 12/13/23, 16:19
Reply
Huh, you are right. Anyway, I wonder why layout is excluded at all. It has no functionality. `pages` and `recursive` are extbase specific. So, I would still remove it at least in main. Eventually we want to get rid of `subtypes_excludelist`. -
Nikita Hovratov uploaded patch set 2
CR +1V +112/13/23, 16:25 -
core-ci voted on patch set 2 V +1 12/13/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50626
-
Oli Bartsch voted on patch set 2 CR +1 V +1 12/18/23, 16:49
-
Stefan Bürk voted on patch set 2 CR +1 V +1 12/19/23, 05:11
-
Oli Bartsch voted on patch set 2 CR +2 V +2 12/19/23, 07:31
-
Oli Bartsch merged patch set 3 12/19/23, 07:31