Review main Merged

82166[BUGFIX] Use proper editor.css path within TYPO3

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 12/11/23, 16:27

Commit message

GeneralUtility::createVersionNumberedFilename() will process the
provided path. It will execute a file_exists check. The file therefore
needs to be resolvable. Applying getPublicResourceWebPath() beforehand
will result in a web url, which can not be resolved on file system
level.
We therefore remove the unnecessary getPublicResourceWebPath() call.
createVersionNumberedFilename() will resolve EXT: paths anyway.

That way TYPO3 can properly handle the file and add the corresponding
version number if configured.
Furthermore this resolves open_basedir restriction issues on configured
systems.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Ludwig +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Ludwig +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Daniel Siepmann uploaded patch set 1 12/11/23, 08:46

  2. core-ci voted on patch set 1 V +1 12/11/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50556

  3. Daniel Siepmann commented on patch set 1 12/11/23, 08:54

    You can test via: - Enable ckeditor system extensions - Open an content element with rte - Verify loaded editor.css file. It should not contain a version number Then apply the patch The file should not contain a version number.
  4. Oli Bartsch voted on patch set 1 CR +1 V +1 12/11/23, 09:39

  5. Christian Ludwig voted on patch set 1 CR +1 V +1 12/11/23, 09:59

  6. Benjamin Franzke voted on patch set 1 CR +1 12/11/23, 10:36

  7. Oliver Klee voted on patch set 1 CR +1 12/11/23, 11:28

  8. Benjamin Franzke voted on patch set 1 CR +2 V +2 12/11/23, 16:06

  9. Benjamin Franzke merged patch set 2 12/11/23, 16:27