Review main Merged

82168[BUGFIX] Prevent TypeError in FileSearchDemand

Oli Bartsch CR +2 V +2 Easy +4 −1 updated 12/18/23, 11:05

Commit message

Since `QueryHelper::parseOrderBy()` might return
NULL as value for fieldname and direction, we
now check those values properly to prevent any
TypeErrors using the type-hinted `addOrdering()`
method.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Thomas Hohn +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Oli Bartsch uploaded patch set 1 12/11/23, 10:15

  2. core-ci voted on patch set 1 V +1 12/11/23, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50561

  3. Oliver Klee voted on patch set 1 CR +1 12/11/23, 11:29

  4. Thomas Hohn voted on patch set 1 CR +1 12/12/23, 14:05

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 12/13/23, 10:34

  6. Stefan Bürk voted on patch set 1 CR +1 V +1 12/18/23, 08:22

  7. Oli Bartsch voted on patch set 1 CR +2 V +2 12/18/23, 10:42

  8. Christian Kuhn voted on patch set 1 CR +1 V +1 12/18/23, 10:47

  9. Oli Bartsch merged patch set 2 12/18/23, 11:05