Review main Abandoned

82174[BUGFIX] Render record history with outdated flexform config

Georg Ringer CR 0 V 0 Easy +8 −3 updated 03/05/24, 14:25

Commit message

Catch exceptions which can happen if a TCA configuration has been
changed and no flexform file is available anymore.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 913

  1. Georg Ringer uploaded patch set 1 12/12/23, 09:51

  2. Georg Ringer commented on patch set 1 12/12/23, 09:51

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 12/12/23, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50581

  4. Benni Mack commented on patch set 2 V +1 12/12/23, 11:14

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V +1 12/12/23, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50584

  6. Christoph Lehmann commented on patch set 2 12/12/23, 14:19

    Unresolved

    This resolves the Exception, but some errors follow... - GeorgRinger\News\Hooks\ItemsProcFunc::getPageId(): Return value must be of type int, null returned - Warning: Trying to access array offset on value of type null (GeorgRinger\News\Hooks\ItemsProcFunc::getPageId()) - Warning: Undefined array key "pid" (TYPO3\CMS\Backend\View\BackendLayoutView::determinePageId at line 138) - Warning: Undefined array key "tx_container_parent" ( B13\Container\Tca\ItemProcFunc::txContainerParent at line 83) and some more. TYPO3\CMS\Backend\Utility\BackendUtility::getProcessedValue() occurs in all their stacktraces
  7. Christian Kuhn commented on patch set 2 CR -1 12/14/23, 12:06

    FlexFormValueFormatter.php:80 Unresolved

    no \Exception: getDataStructureIdentifier() throws dedicated exceptions. catch those.
  8. Georg Ringer uploaded patch set 3 CR -1 V +1 02/07/24, 09:27

  9. core-ci voted on patch set 3 V +1 02/07/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52838

  10. Georg Ringer commented on patch set 4 V +1 02/07/24, 12:16

    Published edit on patch set 3.
  11. core-ci voted on patch set 4 V +1 02/07/24, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52854

  12. Christian Kuhn commented on patch set 4 CR -1 02/09/24, 10:16

    FlexFormValueFormatter.php:81 Unresolved

    why do we need to catch a global \RuntimeException in a view related backend component? where is it thrown and how can an editor trigger this exactly?
  13. Georg Ringer abandoned the change 03/05/24, 14:25