Review main Merged

82178[BUGFIX] Avoid exception on trailing comma in include_static_file.txt

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 12/12/23, 15:53

Commit message

If an entry in the include_static_file.txt file contains a trailing
comma, a RuntimeException (1651137904) is thrown. The problem is a
check whether the path contains 'EXT:', in this case the second path
is an empty string and hence the exception is thrown.

The change removes empty strings when splitting the entries in the
file by comma.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stephan Großberndt +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1519

  1. Thomas Hohn uploaded patch set 1 12/12/23, 12:54

  2. core-ci voted on patch set 1 V +1 12/12/23, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50590

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 12/12/23, 13:13

  4. Mathias Brodala updated the commit message in patch set 2 CR +1 V +1 12/12/23, 13:16

  5. Georg Ringer voted on patch set 2 CR +1 V +1 12/12/23, 13:17

  6. Stephan Großberndt updated the commit message in patch set 3 CR +1 V +1 12/12/23, 13:20

  7. Stephan Großberndt voted on patch set 3 CR +1 12/12/23, 13:20

  8. core-ci voted on patch set 2 V +1 12/12/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50591

  9. core-ci voted on patch set 3 V +1 12/12/23, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50592

  10. Benni Mack voted on patch set 3 CR +1 V +1 12/12/23, 14:14

  11. Stefan Bürk voted on patch set 3 CR -1 12/12/23, 14:25

  12. Stefan Bürk commented on patch set 3 12/12/23, 14:26

    Line break in commit message changed to too long lines by the edit from Stephan.
  13. Stefan Bürk updated the commit message in patch set 4 CR +1 V +1 12/12/23, 14:27

  14. Stefan Bürk voted on patch set 4 CR +1 V +1 12/12/23, 14:27

  15. core-ci voted on patch set 4 V +1 12/12/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50597

  16. Oliver Klee voted on patch set 4 CR +1 12/12/23, 15:39

  17. Stephan Großberndt commented on patch set 4 CR +1 12/12/23, 15:51

    thanks
  18. Benni Mack voted on patch set 4 CR +2 V +2 12/12/23, 15:53

  19. Benni Mack merged patch set 5 12/12/23, 15:53