Review main Merged

82190[TASK] Sanitize embedded HTML in Installation-Wide Configuration GUI

Benjamin Franzke CR +2 V +2 Easy +6 −6 updated 12/19/23, 08:02

Commit message

Input data is statically provided by EXT:core only, so there is no
security issue known right now. This change is a preparation to avoid
possible future security issues.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1115

  1. Benjamin Franzke uploaded patch set 1 12/15/23, 10:11

  2. core-ci voted on patch set 1 V -1 12/15/23, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50675

  3. Benjamin Franzke uploaded patch set 2 V -1 12/15/23, 12:31

  4. core-ci voted on patch set 2 V +1 12/15/23, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50693

  5. Benjamin Franzke uploaded patch set 3 V +1 12/15/23, 12:49

  6. core-ci voted on patch set 3 V +1 12/15/23, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50695

  7. Oli Bartsch commented on patch set 3 12/18/23, 16:39

    SubSection.html:125

    Why only for this type? The description will always be rendered the same way, no matter the item.type so I think we should adjust the other places, too?
  8. Benjamin Franzke uploaded patch set 4 V +1 12/19/23, 07:19

  9. Benjamin Franzke commented on patch set 4 12/19/23, 07:19

    SubSection.html:125 Reply

    ACK, I failed when I moved from controller-side sanitiation to sanitization in tmeplate between patchset 2 and 3. Thanks! Fixed.
  10. Benjamin Franzke commented on patch set 4 12/19/23, 07:21

    SubSection.html:125 Reply

    Done
  11. core-ci voted on patch set 4 V +1 12/19/23, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50784

  12. Oli Bartsch voted on patch set 4 CR +1 V +1 12/19/23, 07:28

  13. Benni Mack voted on patch set 4 CR +1 V +1 12/19/23, 07:32

  14. Oli Bartsch voted on patch set 4 CR +2 V +2 12/19/23, 07:44

  15. Oli Bartsch merged patch set 5 12/19/23, 08:02