Review main Merged Breaking

82195[!!!][TASK] Remove admin user account check in ext:reports

Torben Hansen CR +2 V +2 Normal +0 −69 updated 12/16/23, 22:57

Commit message

In the early versions of TYPO3, "admin" and "password" were set as
the default login credentials. However, this practice was
discontinued long time ago, and the TYPO3 installation process has
since been updated to require users to set their own admin username
and password during installation.

Despite this change, a system report check for the "admin/password"
credentials remained in place. This check was originally intended
to ensure security by notifying administrators if these weak default
credentials were still being used. However, given that TYPO3 has not
used these default credentials for many versions now, this check has
become more or less useless, since it only covers one particular
scenario with weak user credentials.

Furthermore, with the introduction of default password policies in
TYPO3 version 12, the likelihood of users being able to set weak
passwords like "password" has been significantly reduced.

With this change, the check for legacy default login credentials
has been removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Torben Hansen uploaded patch set 1 12/16/23, 13:09

  2. core-ci voted on patch set 1 V +1 12/16/23, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50739

  3. Oliver Klee voted on patch set 1 CR +1 V +1 12/16/23, 16:24

  4. Benni Mack voted on patch set 1 CR +1 12/16/23, 19:56

  5. Benni Mack voted on patch set 1 CR +2 V +2 12/16/23, 22:57

  6. Benni Mack merged patch set 2 12/16/23, 22:57