Review 12.4 Merged

82248[BUGFIX] Omit calling `getRecordWSOL` in `BU::getProcessedValue()`

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 12/26/23, 20:20

Commit message

Since #102616, itemsProcFunc config is resolved in
`BU::getLabelFromItemlist()`. This method therefore
was adjusted to take the record in question as argument,
passing it to the underlying `ItemProcessingService`,
which actually just requires the uid and pid.

Since the database row is not passed to
BU::getProcessedValue()`, the record was
fetched for each item manually via
`getRecordWSOL()`. This is not sufficient
and has a serious performance impact.

The functionality of resolving itemsProcFunc is
now still in place but `BU::getProcessedValue()`
does no longer fetch and pass the record, but
only the uid and pid. This will therefore still
enable most use cases, but does no longer slow
down the backend.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 1