Review 12.4 Merged

82251[BUGFIX] Respect empty alt attribute in ImageViewhelper

Anja Leichsenring CR +2 V +2 Easy +47 −2 updated 01/03/24, 06:10

Commit message

The ImageViewhelper does by default add the
`alternative` property as `alt` attribute to
the img tag if no non-empty string is set.

However, there might be valid use cases where
an empty `alt` attribute should be set for such
image - even if the property exists. Such case
is e.g. a thumbnail of such image.

The ImageViewhelper does therefore now render
an empty `alt` attribute if the `alt` argument
is explicitly set to an empty string.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Anja Leichsenring commented on patch set 1 01/03/24, 06:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/03/24, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51062

  3. Anja Leichsenring voted on patch set 1 CR +2 V +2 01/03/24, 06:10

  4. Anja Leichsenring merged patch set 2 01/03/24, 06:10