Review main Merged

82255[TASK] Ensure removing dangling images works with podman

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 12/19/23, 15:35

Commit message

The TYPO3 core `runTests.sh` contains the `-u` option to
update the images and remove dangling images. Providing
an image name and a `--filter` option is not supported
by podman:
 > Error: cannot specify an image and a filter(s)
 and has not been discovered yet in the TYPO3
core implementation yet.

Both container runtimes `docker` and `podman` support filtering images
using the `reference` filter option. Therefore, this change modifies
the dangling image removal to use multiple filters

To verify that filtering with two `--filter` options can be used with
podman and docker, the following commands can be executed to list the
set of local non-dangling images.

Note: This example uses `dangling=false` instead of
	  `dangling=true` (as in `runTests.sh`), since we expect
      most developers don't have dangling images yet.

> podman images \
    --filter "reference=ghcr.io/typo3/core-testing-*" \
    --filter "dangling=false" --format "{{.ID}}"

> docker images \
    --filter "reference=ghcr.io/typo3/core-testing-*" \
    --filter "dangling=false" --format "{{.ID}}"

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Stefan Bürk uploaded patch set 1 12/19/23, 10:07

  2. core-ci voted on patch set 1 V +1 12/19/23, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50801

  3. Benjamin Franzke updated the commit message in patch set 2 V +1 12/19/23, 10:47

  4. Benjamin Franzke commented on patch set 2 12/19/23, 10:47

    I guess this should read `ghcr.io/typo3/core-testing`. Also this line is missing a trailing `\`. (same applies for the docker example below). Done.
  5. Oli Bartsch voted on patch set 2 CR +1 V +1 12/19/23, 10:49

  6. core-ci voted on patch set 2 V +1 12/19/23, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50803

  7. Oliver Klee voted on patch set 2 CR +1 V +1 12/19/23, 11:20

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 12/19/23, 13:40

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 12/19/23, 15:12

  10. Stefan Bürk merged patch set 3 12/19/23, 15:35