Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
82257[TASK] Adds switch to TS template Module for respecting hidden state
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/57/82257/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/57/82257/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/tstemplate/Classes/Controller/ActiveTypoScriptController.php2+15 −0
- typo3/sysext/tstemplate/Configuration/Backend/Modules.php+1 −0
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_active.xlf+3 −0
- typo3/sysext/tstemplate/Resources/Private/Partials/ActiveOptions.fluid.html+21 −0
- typo3/sysext/tstemplate/Resources/Private/Templates/ActiveMain.fluid.html+1 −0
Review log 1318
-
Daniel Hoffmann uploaded patch set 1 12/19/23, 15:13
-
Daniel Hoffmann updated the commit message in patch set 2 12/19/23, 15:14
-
core-ci voted on patch set 1 V +1 12/19/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50814
-
core-ci voted on patch set 2 V +1 12/19/23, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50818
-
Simon Schaufelberger commented on patch set 2 12/20/23, 09:37
this patch misses a feature rest file which documents the new feature -
Christian Kuhn commented on patch set 2 12/20/23, 10:09
Maybe it would be better to instead just mark such templates as hidden in 'included typoscript' view? For 'active typoscript' we could eventually add a hint that some hidden record is involved in the template parsing? Background: I would rather try to avoid another toggle. Maybe, if we find a way to resolve the Context hack, that would be acceptable, but then, i'd only render that toggle box *if* there are hidden records at all?ActiveTypoScriptController.php:106resetting context in a controller is hacky. i would love to avoid this somehow. -
Christian Kuhn commented on patch set 2 12/20/23, 10:10
Unresolved
Also, I'd say a patch in this area would rather qualify as a task than a feature, in which case we wouldn't need a .rst file. -
Daniel Hoffmann uploaded patch set 3
V +112/20/23, 10:22 -
core-ci voted on patch set 3 V +1 12/20/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50840
-
Daniel Hoffmann commented on patch set 3 12/20/23, 10:35
Reply
DoneReply Unresolved
But then I would do it the other way round. Do not include the hidden data records and add a note that there are hidden data records that may change the result if you show them. Then the term "Active Typoscript" would also fit better.ActiveTypoScriptController.php:106Reply UnresolvedI agree, but in my opinion it is currently the only possible solution for not including the hidden ones. -
Oliver Hader updated the commit message in patch set 4
V +110/18/24, 14:07 -
Benni Mack wrote 04/12/25, 12:16
Hashtag added: lolli-feedback -
Benni Mack updated the commit message in patch set 5 04/22/26, 06:25
-
core-ci voted on patch set 5 V -1 04/22/26, 06:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100692
-
Christian Kuhn wrote 06/18/26, 23:04
Removed cc Christian Kuhn. -
Benni Mack uploaded patch set 6
V -111/10/26, 13:03 -
core-ci voted on patch set 6 V +1 11/10/26, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113899
-
Benni Mack commented on patch set 6 11/10/26, 13:23
Unresolved
I stumbled over this change while reworking this area. https://review.typo3.org/c/Packages/TYPO3.CMS/+/96936 - @d.hoffmann@mac.com what do you think, is that OK for you?