Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review

82257[TASK] Adds switch to TS template Module for respecting hidden state

Daniel Hoffmann CR 0 V 0 Easy +41 −0 updated 11/10/26, 13:23

Commit message

With the switch active only visible sys_template entries
are shown in the configuration tree.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 6
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/57/82257/6 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/57/82257/6 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 5

Review log 1318

  1. Daniel Hoffmann uploaded patch set 1 12/19/23, 15:13

  2. Daniel Hoffmann updated the commit message in patch set 2 12/19/23, 15:14

  3. core-ci voted on patch set 1 V +1 12/19/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50814

  4. core-ci voted on patch set 2 V +1 12/19/23, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50818

  5. Simon Schaufelberger commented on patch set 2 12/20/23, 09:37

    this patch misses a feature rest file which documents the new feature
  6. Christian Kuhn commented on patch set 2 12/20/23, 10:09

    Maybe it would be better to instead just mark such templates as hidden in 'included typoscript' view? For 'active typoscript' we could eventually add a hint that some hidden record is involved in the template parsing? Background: I would rather try to avoid another toggle. Maybe, if we find a way to resolve the Context hack, that would be acceptable, but then, i'd only render that toggle box *if* there are hidden records at all?

    ActiveTypoScriptController.php:106

    resetting context in a controller is hacky. i would love to avoid this somehow.
  7. Christian Kuhn commented on patch set 2 12/20/23, 10:10

    Unresolved

    Also, I'd say a patch in this area would rather qualify as a task than a feature, in which case we wouldn't need a .rst file.
  8. Daniel Hoffmann uploaded patch set 3 V +1 12/20/23, 10:22

  9. core-ci voted on patch set 3 V +1 12/20/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50840

  10. Daniel Hoffmann commented on patch set 3 12/20/23, 10:35

    Reply

    Done

    Reply Unresolved

    But then I would do it the other way round. Do not include the hidden data records and add a note that there are hidden data records that may change the result if you show them. Then the term "Active Typoscript" would also fit better.

    ActiveTypoScriptController.php:106 Reply Unresolved

    I agree, but in my opinion it is currently the only possible solution for not including the hidden ones.
  11. Oliver Hader updated the commit message in patch set 4 V +1 10/18/24, 14:07

  12. Benni Mack wrote 04/12/25, 12:16

    Hashtag added: lolli-feedback
  13. Benni Mack updated the commit message in patch set 5 04/22/26, 06:25

  14. core-ci voted on patch set 5 V -1 04/22/26, 06:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100692

  15. Christian Kuhn wrote 06/18/26, 23:04

    Removed cc Christian Kuhn.
  16. Benni Mack uploaded patch set 6 V -1 11/10/26, 13:03

  17. core-ci voted on patch set 6 V +1 11/10/26, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113899

  18. Benni Mack commented on patch set 6 11/10/26, 13:23

    Unresolved

    I stumbled over this change while reworking this area. https://review.typo3.org/c/Packages/TYPO3.CMS/+/96936 - @d.hoffmann@mac.com what do you think, is that OK for you?