Review main Merged

82262[BUGFIX] Prevent 'Undefined array key' in FileDeletionAspect

Oli Bartsch CR +2 V +2 Easy +13 −7 updated 12/21/23, 23:06

Commit message

Properly check for valid meta data record
to prevent 'Undefined array key' error on
deleting a file.

Meta data record might not exists, because
the file might have not been indexed or
simply because the record was manually deleted.

Additionally, some code clean up is done.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Oli Bartsch uploaded patch set 1 12/20/23, 11:50

  2. core-ci voted on patch set 1 V +1 12/20/23, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50843

  3. Oliver Klee updated the commit message in patch set 2 V +1 12/20/23, 11:58

  4. Oliver Klee voted on patch set 2 CR +1 12/20/23, 11:59

  5. core-ci voted on patch set 2 V +1 12/20/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50844

  6. Jörg Bösche voted on patch set 2 CR +1 12/20/23, 13:42

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 12/21/23, 06:31

  8. Nikita Hovratov voted on patch set 2 CR +2 V +2 12/21/23, 22:56

  9. Nikita Hovratov merged patch set 3 12/21/23, 23:06