Review main Merged

82274[TASK] Proper core require in styleguide composer.json

Christian Kuhn CR +2 V +2 Easy +6 −0 updated 12/23/23, 12:13

Commit message

Before styleguide has been merged to monorepo, it did
not have composer require definitions to core since
that gave ugly cross dependencies between monorepo
and styleguide repo.

With styleguide being merged into monorepo v13, we
can finally safely set a core requirement just like
all other core extensions do.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 12/23/23, 06:31

  2. core-ci voted on patch set 1 V +1 12/23/23, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50923

  3. Oliver Klee voted on patch set 1 CR +1 V +1 12/23/23, 09:42

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 12/23/23, 12:13

  5. Stefan Bürk merged patch set 2 12/23/23, 12:13