82275[TASK] Avoid TSFE->linkVars
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Anja Leichsenring +1
- Sascha Nowak +1
-
Verified V +2 Done
- Benni Mack +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/LinkHandling/TypoLinkCodecService.php1+2 −5
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+10 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −29
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+22 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+0 −11
- typo3/sysext/redirects/Classes/Service/RedirectService.php+3 −1
Review log 1724
-
Christian Kuhn uploaded patch set 1 12/23/23, 09:38
-
core-ci voted on patch set 1 V +1 12/23/23, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50924
-
Christian Kuhn uploaded patch set 2
V +112/23/23, 11:58 -
core-ci voted on patch set 2 V +1 12/23/23, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50927
-
Christian Kuhn uploaded patch set 3
V +112/23/23, 12:04 -
core-ci voted on patch set 3 V +1 12/23/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50928
-
Christian Kuhn updated the commit message in patch set 4
V +112/23/23, 12:10 -
core-ci voted on patch set 4 V +1 12/23/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50929
-
Stefan Bürk voted on patch set 4 CR +1 12/23/23, 12:33
-
Christian Kuhn uploaded patch set 5
CR +1V +112/23/23, 12:45 -
core-ci voted on patch set 5 V -1 12/23/23, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50930
-
Sascha Nowak voted on patch set 5 CR +1 12/29/23, 07:22
-
Christian Kuhn rebased onto patch set 6
CR +1V -112/30/23, 12:49 -
core-ci voted on patch set 6 V -1 12/30/23, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51012
-
Christian Kuhn uploaded patch set 7
V -112/30/23, 13:11 -
Christian Kuhn commented on patch set 7 12/30/23, 13:13
patch set 5 had a rebase error. fixed now. -
core-ci voted on patch set 7 V +1 12/30/23, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51016
-
Sascha Nowak voted on patch set 7 CR +1 12/30/23, 13:48
-
Nikita Hovratov commented on patch set 7 12/30/23, 22:07
TypoLinkCodecService.php:88Just a question: I thought inlining returns is bad because it makes step debugging harder. Has this changed now? -
Benni Mack voted on patch set 7 CR +1 V +1 01/02/24, 07:11
-
Oli Bartsch voted on patch set 7 CR +1 01/02/24, 09:40
-
Anja Leichsenring voted on patch set 7 CR +1 V +1 01/03/24, 06:30
-
Benni Mack voted on patch set 7 CR +2 V +2 01/03/24, 08:13
-
Benni Mack merged patch set 8 01/03/24, 08:13