Review main Merged

82275[TASK] Avoid TSFE->linkVars

Christian Kuhn CR +2 V +2 Normal +37 −50 updated 01/03/24, 08:13

Commit message

TypoScriptFrontendController->linkVars is only used once
in PageLinkBuilder. The TSFE property can be avoided quite
easily by moving the calculation of "global" query
parameters to this place directly. This avoids yet another
dependency to TSFE.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Sascha Nowak +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1724

  1. Christian Kuhn uploaded patch set 1 12/23/23, 09:38

  2. core-ci voted on patch set 1 V +1 12/23/23, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50924

  3. Christian Kuhn uploaded patch set 2 V +1 12/23/23, 11:58

  4. core-ci voted on patch set 2 V +1 12/23/23, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50927

  5. Christian Kuhn uploaded patch set 3 V +1 12/23/23, 12:04

  6. core-ci voted on patch set 3 V +1 12/23/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50928

  7. Christian Kuhn updated the commit message in patch set 4 V +1 12/23/23, 12:10

  8. core-ci voted on patch set 4 V +1 12/23/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50929

  9. Stefan Bürk voted on patch set 4 CR +1 12/23/23, 12:33

  10. Christian Kuhn uploaded patch set 5 CR +1 V +1 12/23/23, 12:45

  11. core-ci voted on patch set 5 V -1 12/23/23, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50930

  12. Sascha Nowak voted on patch set 5 CR +1 12/29/23, 07:22

  13. Christian Kuhn rebased onto patch set 6 CR +1 V -1 12/30/23, 12:49

  14. core-ci voted on patch set 6 V -1 12/30/23, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51012

  15. Christian Kuhn uploaded patch set 7 V -1 12/30/23, 13:11

  16. Christian Kuhn commented on patch set 7 12/30/23, 13:13

    patch set 5 had a rebase error. fixed now.
  17. core-ci voted on patch set 7 V +1 12/30/23, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51016

  18. Sascha Nowak voted on patch set 7 CR +1 12/30/23, 13:48

  19. Nikita Hovratov commented on patch set 7 12/30/23, 22:07

    TypoLinkCodecService.php:88

    Just a question: I thought inlining returns is bad because it makes step debugging harder. Has this changed now?
  20. Benni Mack voted on patch set 7 CR +1 V +1 01/02/24, 07:11

  21. Oli Bartsch voted on patch set 7 CR +1 01/02/24, 09:40

  22. Anja Leichsenring voted on patch set 7 CR +1 V +1 01/03/24, 06:30

  23. Benni Mack voted on patch set 7 CR +2 V +2 01/03/24, 08:13

  24. Benni Mack merged patch set 8 01/03/24, 08:13