Review main Merged

82284[FEATURE] Use Symfony attribute to autoconfigure message handler

Sascha Nowak CR +2 V +2 Normal +103 −8 updated 01/03/24, 21:49

Commit message

Message handlers had to be registered in the extensions
`Services.yaml` file with the `messenger.message_handler` tag.

This patch enables automatic message handlers registration
by using the existing `\Symfony\Component\Messenger\Attribute\AsMessageHandler`
symfony PHP attribute.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 913

  1. Sascha Nowak uploaded patch set 1 12/29/23, 06:58

  2. core-ci voted on patch set 1 V +1 12/29/23, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50993

  3. Benni Mack updated the commit message in patch set 2 V +1 01/02/24, 21:02

  4. core-ci voted on patch set 2 V +1 01/02/24, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51054

  5. Anja Leichsenring commented on patch set 3 V +1 01/03/24, 06:09

    Published edit on patch set 2.
  6. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/03/24, 06:09

  7. core-ci voted on patch set 3 V +1 01/03/24, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51063

  8. Oli Bartsch uploaded patch set 4 CR +1 V +1 01/03/24, 15:07

  9. Oli Bartsch voted on patch set 4 CR +1 V +1 01/03/24, 15:08

  10. core-ci voted on patch set 4 V +1 01/03/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51079

  11. Daniel Goerz voted on patch set 4 CR +1 V +1 01/03/24, 18:27

  12. Benni Mack voted on patch set 4 CR +2 V +2 01/03/24, 21:49

  13. Benni Mack merged patch set 5 01/03/24, 21:49