82291[TASK] Remove unused language labels in ext:reports
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 1
Review log 67
-
Torben Hansen uploaded patch set 1 12/30/23, 17:51
-
core-ci voted on patch set 1 V +1 12/30/23, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51026
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 12/30/23, 19:02
-
Oli Bartsch commented on patch set 1 01/02/24, 06:54
It seems as `status_configuration_PhpSafeModeEnabled` and `status_configuration_PhpMagicQuotesGpcEnabled` are unused, too. -
Torben Hansen commented on patch set 1 01/02/24, 08:17
Reply
Are there any other occurrences of `status_configuration_PhpSafeModeEnabled` and `status_configuration_PhpMagicQuotesGpcEnabled` I did miss? The patch removes both values from the language file and I can not find any other places, where those strings are used. -
Oli Bartsch commented on patch set 1 CR +2 V +2 01/02/24, 09:07
Reply
My fault, grep'ed while patch was not applied. -
Oli Bartsch merged patch set 2 01/02/24, 09:07