Review main Merged

82292[TASK] Update `alwan` to 2.0.1

Andreas Kienast CR +2 V +2 Hard +301 −229 updated 01/03/24, 13:23

Commit message

This patch updates `alwan`, the used color picker library, to version
2.0.1. Since this a major version update, CSS needs adjustments.

Executed command:

    npm install --save alwan@^2.0.1
    npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1115

  1. Andreas Kienast uploaded patch set 1 12/31/23, 15:44

  2. Andreas Kienast commented on patch set 1 CR -1 12/31/23, 15:45

    Needs remaining rtl adjustments.
  3. Andreas Kienast uploaded patch set 2 CR -1 12/31/23, 15:50

  4. core-ci voted on patch set 1 V -1 12/31/23, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51033

  5. Andreas Kienast uploaded patch set 3 12/31/23, 15:53

  6. core-ci voted on patch set 2 V -1 12/31/23, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51034

  7. core-ci voted on patch set 3 V +1 12/31/23, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51035

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/03/24, 06:42

  9. Benjamin Franzke commented on patch set 3 CR -1 01/03/24, 12:20

    alwan did not went into v12 – so no backport..
  10. Benjamin Franzke uploaded patch set 4 CR +1 V +1 01/03/24, 12:33

  11. Benjamin Franzke commented on patch set 4 01/03/24, 12:33

    Reply

    Done

    color-picker.ts:15

    Seems like alwanEvent is better be used implicitly, as alwanEvent is not exposed as public API. I'd simply let TypeScript infer the type from the `alwan.on()` parameter definitions, and rather avoid importing from private resources. Done.
  12. core-ci voted on patch set 4 V +1 01/03/24, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51076

  13. Oli Bartsch voted on patch set 4 CR +1 V +1 01/03/24, 13:12

  14. Benjamin Franzke voted on patch set 4 CR +2 V +2 01/03/24, 13:23

  15. Benjamin Franzke merged patch set 5 01/03/24, 13:23