Review main Merged

82297[BUGFIX] Fetch original file from file reference in ThumbnailViewHelper

Oli Bartsch CR +2 V +2 Easy +5 −5 updated 01/05/24, 14:31

Commit message

Using `treatIdAsReference` it's also possible to
pass a file reference uid to the ThumbnailViewHelper.

To allow processing such reference, the original
file is now fetched to call `process` on it.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Oli Bartsch uploaded patch set 1 01/02/24, 13:52

  2. core-ci voted on patch set 1 V -1 01/02/24, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51050

  3. Oliver Klee commented on patch set 1 01/02/24, 14:21

    This fix solves a (valid) PHPStan warning (yay!). So we'll need to regenerate the PHPStan baseline.
  4. Oli Bartsch uploaded patch set 2 V -1 01/02/24, 15:15

  5. core-ci voted on patch set 2 V +1 01/02/24, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51051

  6. Oli Bartsch commented on patch set 2 01/02/24, 15:31

    Reply

    yeah 🎉
  7. Oliver Klee voted on patch set 2 CR +1 01/02/24, 20:15

  8. Benni Mack updated the commit message in patch set 3 CR +1 V +1 01/02/24, 21:01

  9. core-ci voted on patch set 3 V +1 01/02/24, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51053

  10. Oliver Klee voted on patch set 3 CR +1 01/02/24, 21:33

  11. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/03/24, 06:06

  12. Benni Mack voted on patch set 3 CR +1 V +1 01/05/24, 12:18

  13. Oli Bartsch voted on patch set 3 CR +2 V +2 01/05/24, 14:31

  14. Oli Bartsch merged patch set 4 01/05/24, 14:31