82300[!!!][TASK] Unify _PAGES_OVERLAY_UID and _LOCALIZED_UID
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 18
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php5+9 −11
- typo3/sysext/core/Classes/Domain/Page.php+3 −6
- typo3/sysext/core/Classes/Routing/PageRouter.php+1 −1
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+1 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102627-RemovedSpecialPropertiesOfPageArraysInPageRepository.rst6new+73 −0
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+21 −28
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/Configuration/TypoScript/JsonRenderer.typoscript+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Configuration/TypoScript/JsonRenderer.typoscript+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/JsonRenderer.typoscript+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+1 −6
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+13 −13
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −2
- typo3/sysext/frontend/Classes/Resource/FileCollector.php+1 −6
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+2 −2
- typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php+2 −2
Review log 2027
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 01/03/24, 10:34
-
core-ci voted on patch set 1 V -1 01/03/24, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51069
-
Benni Mack uploaded patch set 2
V -101/03/24, 11:40 -
core-ci voted on patch set 2 V +1 01/03/24, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51074
-
Benni Mack uploaded patch set 3
V +101/03/24, 17:14 -
core-ci voted on patch set 3 V -1 01/03/24, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51084
-
Chris Müller commented on patch set 3 01/03/24, 17:34
-
Benni Mack uploaded patch set 4
V -101/03/24, 21:14 -
Benni Mack commented on patch set 3 01/03/24, 21:14
Breaking-102627-RemovedSpecialPropertiesOfPageArraysInPageRepository.rst:64Replyyou are right, fixed -
core-ci voted on patch set 4 V +1 01/03/24, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51087
-
Simon Schaufelberger commented on patch set 4 01/04/24, 01:16
anBreaking-102627-RemovedSpecialPropertiesOfPageArraysInPageRepository.rst:33due to? -
Benni Mack commented on patch set 5
V +101/04/24, 08:13Published edit on patch set 4. -
Benni Mack updated the commit message in patch set 6 01/04/24, 08:13
-
core-ci voted on patch set 5 V +1 01/04/24, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51097
-
core-ci voted on patch set 6 V +1 01/04/24, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51098
-
Benni Mack commented on patch set 6 01/04/24, 08:32
Reply
DoneBreaking-102627-RemovedSpecialPropertiesOfPageArraysInPageRepository.rst:33ReplyDone -
Oli Bartsch commented on patch set 6 01/04/24, 12:53
PageRepository.php:642Using another column name than `sys_language_uid` will no break the overlay functionality since ['ctrl']['languageField'] is no longer respected, but we use the hard-coded name instead. -
Simon Schaufelberger commented on patch set 6 01/04/24, 12:59
Breaking-102627-RemovedSpecialPropertiesOfPageArraysInPageRepository.rst:34"and are used to it for historical reasons" would be easier to understand. "used to due to..." is this corrrect english? -
Benni Mack commented on patch set 6 01/04/24, 14:39
PageRepository.php:642ReplyI don't understand your comment -
Oli Bartsch commented on patch set 6 01/04/24, 15:09
PageRepository.php:642ReplyInstead of setting `_PAGES_OVERLAY_LANGUAGE` to the value of `$row[$languageField]`, while `$languageField` represents the configured `TCA[ctrl][languageField]` value, we now use hard-coded `sys_language_uid`. This means, in case a developer does use a different field name in `TCA[ctrl][languageField]`, overlay functionality will break since there might be no `sys_language_uid` field at all. -
Benni Mack commented on patch set 7
V +101/05/24, 08:24Published edit on patch set 6. -
Benni Mack commented on patch set 7 01/05/24, 08:24
PageRepository.php:642Replythat would influence many other places then, can be handled separatelyBreaking-102627-RemovedSpecialPropertiesOfPageArraysInPageRepository.rst:34ReplyDone -
Oli Bartsch commented on patch set 7 CR +1 V +1 01/05/24, 08:25
PageRepository.php:642ReplyACK -
core-ci voted on patch set 7 V +1 01/05/24, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51127
-
Stefan Bürk voted on patch set 7 CR +1 V +1 01/06/24, 15:08
-
Benni Mack voted on patch set 7 CR +2 V +2 01/06/24, 20:35
-
Benni Mack merged patch set 8 01/06/24, 20:35
Breaking-102627-RemovedSpecialPropertiesOfPageArraysInPageRepository.rst:64