Review main Merged

82304[TASK] Allow usage of symfony 7

Benni Mack CR +2 V +2 Hard +356 −356 updated 01/04/24, 11:53

Commit message

This change enables symfony 7 in
addition to symfony 6 in TYPO3.

Symfony7 requires PHP 8.2, thus
is not installed by default for the
time being, as this change is also
allowed for TYPO3 v12 support when
running with PHP 8.2 and composer.

Used commands:

composer req -W \
 "symfony/config:^6.4 || ^7.0" \
 "symfony/console:^6.4 || ^7.0" \
 "symfony/dependency-injection:^6.4 || ^7.0" \
 "symfony/doctrine-messenger:^6.4 || ^7.0" \
 "symfony/expression-language:^6.4 || ^7.0" \
 "symfony/filesystem:^6.4 || ^7.0" \
 "symfony/finder:^6.4 || ^7.0" \
 "symfony/http-foundation:^6.4 || ^7.0" \
 "symfony/mailer:^6.4 || ^7.0" \
 "symfony/messenger:^6.4 || ^7.0" \
 "symfony/mime:^6.4 || ^7.0" \
 "symfony/options-resolver:^6.4 || ^7.0" \
 "symfony/property-access:^6.4 || ^7.0" \
 "symfony/property-info:^6.4 || ^7.0" \
 "symfony/rate-limiter:^6.4 || ^7.0" \
 "symfony/routing:^6.4 || ^7.0" \
 "symfony/uid:^6.4 || ^7.0" \
 "symfony/var-dumper:^6.4 || ^7.0" \
 "symfony/yaml:^6.4 || ^7.0"

 composer req --dev -W \
 "codeception/codeception:^5.0.13" \
 "codeception/module-filesystem:^3.0.1" \
 "friendsofphp/php-cs-fixer:^3.46" \
 "symfony/translation:^6.4 || ^7.0"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 1418

  1. Benni Mack uploaded patch set 1 01/03/24, 16:28

  2. core-ci voted on patch set 1 V -1 01/03/24, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51080

  3. Benni Mack uploaded patch set 2 V -1 01/03/24, 16:39

  4. core-ci voted on patch set 2 V +1 01/03/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51082

  5. Oliver Klee voted on patch set 2 CR +1 V +1 01/03/24, 17:18

  6. Benni Mack updated the commit message in patch set 3 CR +1 V +1 01/03/24, 21:49

  7. core-ci voted on patch set 3 V +1 01/03/24, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51088

  8. Oliver Klee voted on patch set 3 CR +1 V +1 01/03/24, 22:02

  9. Simon Schaufelberger commented on patch set 3 CR +1 V +1 01/03/24, 22:15

    I guess we can simply trust on test coverage here.
  10. Benni Mack uploaded patch set 4 CR +1 V +1 01/04/24, 08:18

  11. core-ci voted on patch set 4 V +1 01/04/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51099

  12. Oliver Klee voted on patch set 4 CR +1 V +1 01/04/24, 09:21

  13. Oliver Klee commented on patch set 4 01/04/24, 09:46

    I see that these version raises are desired (as they're also mentioned in the commit message), but I currently don't know the reason for the raise (as the build was green at least without the PHP-CS-FIxer raise as well). Maybe a sentence in the commit message explaining why we're raising these two Codeception packages and PHP-CS-Fixer (instead of having those as separate changes) would be helpful to understand why that's necessary.
  14. Stefan Bürk commented on patch set 4 CR +1 V +1 01/04/24, 10:10

    Reply

    For example, codeception added support for symfony 7 wit 5.0.13, see release notes: https://github.com/Codeception/Codeception/releases - and the second package I guess imply for compat but not checked. cs-fixer added / stabilized symfony 7 support with https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases/tag/v3.41.0. So raising are required to stand on save ground. As these are "only" monorepo development dependency, raising them are fine. Note - unless you test with php8.2+ and composerInstall max you wont get symfony 7, and it's normal to have green tests with old symfony6 and without these dependencies. No need for a note in the commit message. I guess, or the v13 core this will be raised to php8.2 and symfony 7 only lateron with a corresponding breaking rest file.
  15. Oliver Klee commented on patch set 4 01/04/24, 10:11

    Reply

    Acknowledged
  16. Oli Bartsch voted on patch set 4 CR +1 V +1 01/04/24, 11:28

  17. Benni Mack voted on patch set 4 CR +2 V +2 01/04/24, 11:53

  18. Benni Mack merged patch set 5 01/04/24, 11:53