82304[TASK] Allow usage of symfony 7
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/adminpanel/Classes/Utility/HtmlDumper.php+1 −1
- typo3/sysext/adminpanel/composer.json+1 −1
- typo3/sysext/core/Classes/Command/DumpAutoloadCommand.php+1 −1
- typo3/sysext/core/Classes/Mail/FluidEmail.php+1 −1
- typo3/sysext/core/Classes/Routing/RouteCollection.php+1 −1
- typo3/sysext/core/composer.json+16 −16
- typo3/sysext/dashboard/Tests/Unit/DependencyInjection/DashboardWidgetPassTest.php+1 −1
- typo3/sysext/extbase/composer.json+3 −3
- typo3/sysext/extensionmanager/Classes/Command/ActivateExtensionCommand.php+1 −1
- typo3/sysext/extensionmanager/Classes/Command/DeactivateExtensionCommand.php+1 −1
- typo3/sysext/fluid/composer.json+1 −1
- typo3/sysext/form/composer.json+1 −1
- typo3/sysext/install/composer.json+2 −2
- typo3/sysext/redirects/composer.json+1 −1
- typo3/sysext/webhooks/composer.json+1 −1
- composer.json+23 −23
- composer.lock+300 −300
Review log 1418
-
Benni Mack uploaded patch set 1 01/03/24, 16:28
-
core-ci voted on patch set 1 V -1 01/03/24, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51080
-
Benni Mack uploaded patch set 2
V -101/03/24, 16:39 -
core-ci voted on patch set 2 V +1 01/03/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51082
-
Oliver Klee voted on patch set 2 CR +1 V +1 01/03/24, 17:18
-
Benni Mack updated the commit message in patch set 3
CR +1V +101/03/24, 21:49 -
core-ci voted on patch set 3 V +1 01/03/24, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51088
-
Oliver Klee voted on patch set 3 CR +1 V +1 01/03/24, 22:02
-
Simon Schaufelberger commented on patch set 3 CR +1 V +1 01/03/24, 22:15
I guess we can simply trust on test coverage here. -
Benni Mack uploaded patch set 4
CR +1V +101/04/24, 08:18 -
core-ci voted on patch set 4 V +1 01/04/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51099
-
Oliver Klee voted on patch set 4 CR +1 V +1 01/04/24, 09:21
-
Oliver Klee commented on patch set 4 01/04/24, 09:46
I see that these version raises are desired (as they're also mentioned in the commit message), but I currently don't know the reason for the raise (as the build was green at least without the PHP-CS-FIxer raise as well). Maybe a sentence in the commit message explaining why we're raising these two Codeception packages and PHP-CS-Fixer (instead of having those as separate changes) would be helpful to understand why that's necessary. -
Stefan Bürk commented on patch set 4 CR +1 V +1 01/04/24, 10:10
Reply
For example, codeception added support for symfony 7 wit 5.0.13, see release notes: https://github.com/Codeception/Codeception/releases - and the second package I guess imply for compat but not checked. cs-fixer added / stabilized symfony 7 support with https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases/tag/v3.41.0. So raising are required to stand on save ground. As these are "only" monorepo development dependency, raising them are fine. Note - unless you test with php8.2+ and composerInstall max you wont get symfony 7, and it's normal to have green tests with old symfony6 and without these dependencies. No need for a note in the commit message. I guess, or the v13 core this will be raised to php8.2 and symfony 7 only lateron with a corresponding breaking rest file. -
Oliver Klee commented on patch set 4 01/04/24, 10:11
Reply
Acknowledged -
Oli Bartsch voted on patch set 4 CR +1 V +1 01/04/24, 11:28
-
Benni Mack voted on patch set 4 CR +2 V +2 01/04/24, 11:53
-
Benni Mack merged patch set 5 01/04/24, 11:53