Review main Merged

82308[BUGFIX] Ensure table wizard connected callback has access to textarea

Benjamin Franzke CR +2 V +2 Easy +2 −3 updated 01/18/24, 13:06

Commit message

The textarea element needs to be available in the DOM before the table
wizard element is rendered, as the connected callback can be triggered
between the rendering of these distinct elements, which would cause
the initialization to fail.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 01/04/24, 08:28

  2. core-ci voted on patch set 1 V +1 01/04/24, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51100

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 01/04/24, 12:39

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 01/18/24, 10:46

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 01/18/24, 11:08

  6. Benjamin Franzke merged patch set 2 01/18/24, 13:06