Review main Merged

82309[BUGFIX] Prevent InvalidArgumentException in user constraints calculation

Oli Bartsch CR +2 V +2 Easy +30 −5 updated 01/05/24, 08:17

Commit message

An additional check is applied to prevent
an InvalidArgumentException for cases where
`checkPid_value` contains an empty string.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Oli Bartsch uploaded patch set 1 01/04/24, 13:33

  2. core-ci voted on patch set 1 V -1 01/04/24, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51104

  3. Markus Klein voted on patch set 1 CR +1 01/04/24, 13:39

  4. Oli Bartsch uploaded patch set 2 CR +1 V -1 01/04/24, 14:04

  5. core-ci voted on patch set 2 V -1 01/04/24, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51105

  6. Oli Bartsch uploaded patch set 3 V -1 01/04/24, 14:14

  7. core-ci voted on patch set 3 V +1 01/04/24, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51106

  8. Oliver Klee voted on patch set 3 CR +1 V +1 01/04/24, 15:01

  9. Markus Klein voted on patch set 3 CR +1 V +1 01/05/24, 01:52

  10. Benni Mack voted on patch set 3 CR +1 V +1 01/05/24, 07:34

  11. Oli Bartsch voted on patch set 3 CR +2 V +2 01/05/24, 08:05

  12. Oli Bartsch merged patch set 4 01/05/24, 08:17