82311[!!!][TASK] Remove ConsumableNonce->b64
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/ConsumableNonce.php+1 −8
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst1+1 −0
- typo3/sysext/core/Tests/Unit/Security/ContentSecurityPolicy/ConsumableNonceTest.php+0 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+5 −0
Review log 1318
-
Simon Schaufelberger uploaded patch set 1 01/04/24, 15:18
-
core-ci voted on patch set 1 V -1 01/04/24, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51109
-
Simon Schaufelberger uploaded patch set 2
V -101/14/24, 23:08 -
core-ci voted on patch set 2 V -1 01/14/24, 23:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51561
-
Simon Schaufelberger uploaded patch set 3
V -101/14/24, 23:24 -
core-ci voted on patch set 3 V +1 01/14/24, 23:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51562
-
Benjamin Franzke commented on patch set 3 CR -1 01/15/24, 07:11
we usually add a `Related` line to the issue that introduced the deprecation.Breaking-102754-RemoveConsumableNonce-b64.rst:14I guess you are still working on this patch? (just asking because it is not currently marked as WIP) -
Benjamin Franzke uploaded patch set 4
CR -1V +101/15/24, 08:24 -
Benjamin Franzke commented on patch set 4 01/15/24, 08:24
Reply
DoneBreaking-102754-RemoveConsumableNonce-b64.rst:14ReplyWe don't need a separate RST here. It is very unlikely that 3rd party code used this. I've rather added it to the general breaking-rst file and also introduced an extension scanner rule to be sure. -
core-ci voted on patch set 4 V +1 01/15/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51567
-
Stefan Bürk voted on patch set 4 CR +1 V +1 01/15/24, 08:35
-
Torben Hansen voted on patch set 4 CR +1 V +1 01/15/24, 09:06
-
Benjamin Franzke uploaded patch set 5
CR +1V +101/15/24, 10:00 -
Benjamin Franzke commented on patch set 5 01/15/24, 10:00
Breaking-100963-DeprecatedFunctionalityRemoved.rst:291Sorry, I messed up the ordering. -
core-ci voted on patch set 5 V +1 01/15/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51571
-
Stefan Bürk voted on patch set 5 CR +1 V +1 01/15/24, 10:52
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 01/15/24, 10:55
-
Benjamin Franzke merged patch set 6 01/15/24, 10:55