Review main Merged Breaking

82311[!!!][TASK] Remove ConsumableNonce->b64

Simon Schaufelberger CR +2 V +2 Easy +7 −9 updated 01/15/24, 10:55

Commit message

It has been deprecated with TYPO3 v12.4.8 and is now removed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1318

  1. Simon Schaufelberger uploaded patch set 1 01/04/24, 15:18

  2. core-ci voted on patch set 1 V -1 01/04/24, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51109

  3. Simon Schaufelberger uploaded patch set 2 V -1 01/14/24, 23:08

  4. core-ci voted on patch set 2 V -1 01/14/24, 23:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51561

  5. Simon Schaufelberger uploaded patch set 3 V -1 01/14/24, 23:24

  6. core-ci voted on patch set 3 V +1 01/14/24, 23:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51562

  7. Benjamin Franzke commented on patch set 3 CR -1 01/15/24, 07:11

    we usually add a `Related` line to the issue that introduced the deprecation.

    Breaking-102754-RemoveConsumableNonce-b64.rst:14

    I guess you are still working on this patch? (just asking because it is not currently marked as WIP)
  8. Benjamin Franzke uploaded patch set 4 CR -1 V +1 01/15/24, 08:24

  9. Benjamin Franzke commented on patch set 4 01/15/24, 08:24

    Reply

    Done

    Breaking-102754-RemoveConsumableNonce-b64.rst:14 Reply

    We don't need a separate RST here. It is very unlikely that 3rd party code used this. I've rather added it to the general breaking-rst file and also introduced an extension scanner rule to be sure.
  10. core-ci voted on patch set 4 V +1 01/15/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51567

  11. Stefan Bürk voted on patch set 4 CR +1 V +1 01/15/24, 08:35

  12. Torben Hansen voted on patch set 4 CR +1 V +1 01/15/24, 09:06

  13. Benjamin Franzke uploaded patch set 5 CR +1 V +1 01/15/24, 10:00

  14. Benjamin Franzke commented on patch set 5 01/15/24, 10:00

    Breaking-100963-DeprecatedFunctionalityRemoved.rst:291

    Sorry, I messed up the ordering.
  15. core-ci voted on patch set 5 V +1 01/15/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51571

  16. Stefan Bürk voted on patch set 5 CR +1 V +1 01/15/24, 10:52

  17. Benjamin Franzke voted on patch set 5 CR +2 V +2 01/15/24, 10:55

  18. Benjamin Franzke merged patch set 6 01/15/24, 10:55