Review main Merged

82352[TASK] Update `phpstan/phpstan:^1.10.51`

Anja Leichsenring CR +2 V +2 Easy +22 −7 updated 01/06/24, 09:34

Commit message

New phpstan find some questionable null fallback occurences, that are
not obvious. Add a baseline for now.

> composer req --dev phpstan/phpstan:^1.10.51
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Thomas Hohn +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Thomas Hohn +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Anja Leichsenring uploaded patch set 1 01/05/24, 06:52

  2. core-ci voted on patch set 1 V +1 01/05/24, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51124

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 01/05/24, 07:02

  4. Thomas Hohn voted on patch set 1 CR +1 V +1 01/05/24, 07:02

  5. Oliver Klee voted on patch set 1 CR +1 V +1 01/05/24, 11:30

  6. Stefan Bürk voted on patch set 1 CR +2 V +2 01/06/24, 09:19

  7. Stefan Bürk merged patch set 2 01/06/24, 09:34