Review main Merged

82354[BUGFIX] Use configured `languageField` in context menu item providers

Oli Bartsch CR +2 V +2 Easy +13 −6 updated 01/09/24, 09:12

Commit message

Replace the hard-coded `sys_language_uid` name
with the actually configured `languageField` value.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Oli Bartsch uploaded patch set 1 01/05/24, 09:23

  2. core-ci voted on patch set 1 V +1 01/05/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51130

  3. Stefan Bürk commented on patch set 1 01/06/24, 14:19

    RecordProvider.php:282

    `getLanguageField()` may return an empty string, which is not covered here.
  4. Oli Bartsch commented on patch set 1 01/06/24, 15:47

    RecordProvider.php:282 Reply

    what would be your suggestion?
  5. Oli Bartsch uploaded patch set 2 V +1 01/08/24, 15:32

  6. Oli Bartsch commented on patch set 2 01/08/24, 15:32

    RecordProvider.php:282 Reply

    Done
  7. core-ci voted on patch set 2 V +1 01/08/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51259

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 01/08/24, 21:16

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 01/09/24, 08:40

  10. Benni Mack voted on patch set 2 CR +1 V +1 01/09/24, 08:50

  11. Oli Bartsch voted on patch set 2 CR +2 V +2 01/09/24, 09:11

  12. Oli Bartsch merged patch set 3 01/09/24, 09:12