Review 12.4 Merged

82358[TASK] Assert result based on symfony version in deprecated code tests

Stefan Bürk CR +2 V +2 Normal +48 −4 updated 01/06/24, 12:08

Commit message

Symfony 7 removed deprecated code paths [1][2] and therefore started
using strict `in_array()` check for the `in` and `notIn` condition in
the expression language.

With #102746 the usage of symfony 7 has been allowed, which itself
introduces breaking changes. It is optional to upgrade to symfony 7
and therefore breaking changes has been respected and excludes from
the TYPO3 policies regarding breaking changes as it is not enforced.

This change modifies two tests to assert results based on the used
symfony version.

[1] https://github.com/symfony/symfony/pull/50867
[2] https://github.com/symfony/symfony/commit/7050bc82dd25c540958

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 813

  1. Stefan Bürk uploaded patch set 1 01/06/24, 10:35

  2. Stefan Bürk updated the commit message in patch set 2 01/06/24, 10:36

  3. core-ci voted on patch set 2 V +1 01/06/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51153

  4. core-ci voted on patch set 2 V -1 01/06/24, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51154

  5. Stefan Bürk rebased onto patch set 3 V -1 01/06/24, 11:33

  6. Stefan Bürk uploaded patch set 4 01/06/24, 11:37

  7. core-ci voted on patch set 3 V +1 01/06/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51156

  8. core-ci voted on patch set 4 V +1 01/06/24, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51157

  9. core-ci commented on patch set 4 01/06/24, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51158

  10. Anja Leichsenring voted on patch set 4 CR +1 V +1 01/06/24, 12:01

  11. Oliver Klee voted on patch set 4 CR +1 V +1 01/06/24, 12:03

  12. Stefan Bürk voted on patch set 4 CR +2 V +2 01/06/24, 12:07

  13. Stefan Bürk merged patch set 5 01/06/24, 12:08