Review 12.4 Merged

82359[TASK] Upgrade `typo3/cms-styleguide`

Stefan Bürk CR +2 V +2 Easy +10 −10 updated 01/06/24, 12:07

Commit message

This change upgrades the `typo3/cms-styleguide` version
to pull in required changes for `symfony 7 compat`. The
culprit was a missing method return type for the funny
`kauderwelsch` command execute method. [1]

Used command(s):

> composer require --dev "typo3/cms-styleguide":"^12.0.3"

Note:   `ext:styleguide` has been integrated into the core
        monorepo starting with v13, but older core version
        still uses the dedicated package and needs to be
        updated manually.

[1] https://github.com/TYPO3-CMS/styleguide/commit/5d2515e051af91a9a2fc

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Stefan Bürk uploaded patch set 1 01/06/24, 11:32

  2. core-ci voted on patch set 1 V +1 01/06/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51155

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 01/06/24, 12:01

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 01/06/24, 12:07

  5. Stefan Bürk merged patch set 2 01/06/24, 12:07