82360[TASK] Unblock argument passing in `Build/Scripts/runTests.sh`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Oliver Klee +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2634
Show 79 earlier messages
-
Stefan Bürk uploaded patch set 1 01/06/24, 21:58
-
core-ci voted on patch set 1 V +1 01/06/24, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51172
-
Oliver Klee updated the commit message in patch set 2
V +101/07/24, 09:03 -
core-ci voted on patch set 2 V +1 01/07/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51182
-
Oliver Klee commented on patch set 2 01/07/24, 19:33
runTests.sh:335Here, I get the same problem about the `-v` switch.runTests.sh:339It seems that this test file does not exist. -
Stefan Bürk commented on patch set 2 01/08/24, 09:28
runTests.sh:292ReplyWhat's your full command line ? Any more information ?runTests.sh:339ReplyYes - seems outdated. Will try to switch to another one .. however, it's a example and most likely can become outdated with any test example we choose (and have to re-evaluated on backports then too). -
Stefan Bürk commented on patch set 2 01/08/24, 09:29
runTests.sh:292Replya wait - outdated to. PHPUnit dropped the `-v` flag - will push and remove that example -
Stefan Bürk uploaded patch set 3
V +101/08/24, 09:41 -
Stefan Bürk commented on patch set 3 01/08/24, 09:42
runTests.sh:292ReplyDonerunTests.sh:335ReplyDonerunTests.sh:339ReplyDone
-
core-ci voted on patch set 3 V +1 01/08/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51207
-
Oliver Klee voted on patch set 3 V +1 01/08/24, 10:26
-
Benjamin Franzke commented on patch set 3 01/08/24, 10:37
runTests.sh:561Hm, I don't quite like how `"… $@"` will "loose" the knowledge of what the exact parameters are. If I pass `-- "foo bar" baz`, it will be passed as three arguments to `codecept` (`"foo"`, `"bar"`, `"baz"` instead of `"foo bar"` and `"baz"`) I'd usually transform COMMAND into a bash array to keep track of the exact passed parameters, but then again we have to face the old bash versions (v3) on that futuristic operating system named MacOS, which doesn't support bash arrays. we basically need to pass `"$@"` (this is a special syntax that will preserve input arguments as-is, see https://www.gnu.org/software/bash/manual/html_node/Special-Parameters.html#index-_0040 ) directly to the docker command, as I don't know how to store these variables properly with support for bash v3. Did a quick test with a shell script, but i'm only to manage to store those variables properly with bash v4: ``` #!/bin/sh # write to test.sh and test with ./test.sh "foo bar" baz # does not work properly, "foo" and "bar" will be passed as separate parameters COMMAND1="prefix $@" php -r 'print_r(array_slice($_SERVER["argv"], 1));' $COMMAND1 # does not work properly, "foo" and "bar" will be passed as separate parameters COMMAND2="prefix ""$@" php -r 'print_r(array_slice($_SERVER["argv"], 1));' "${COMMAND2[@]}" # bash v4 only, will pass "foo bar" as-is declare -a COMMAND3 COMMAND3=( "prefix" ) COMMAND3+=( "$@" ) php -r 'print_r(array_slice($_SERVER["argv"], 1));' "${COMMAND3[@]}" ``` -
Stefan Bürk commented on patch set 3 01/08/24, 11:02
runTests.sh:561ReplyWould using "$@" okay for you ? I push it with that than. Don't get it why I did not used that directly as I normally always use that. -
Stefan Bürk uploaded patch set 4
V +101/08/24, 11:07 -
core-ci voted on patch set 4 V -1 01/08/24, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51219
-
Stefan Bürk uploaded patch set 5
V -101/08/24, 11:19 -
Stefan Bürk commented on patch set 5 01/08/24, 11:20
runTests.sh:561ReplyNot really working yet - will postpone this for now as have no time currently for it. However, thanks for the input Benjamin. -
Stefan Bürk abandoned the change 01/08/24, 11:35
-
Stefan Bürk restored the change 01/08/24, 12:38
-
Benjamin Franzke uploaded patch set 6 01/08/24, 12:44
-
Benjamin Franzke commented on patch set 6 01/08/24, 12:46
runTests.sh:561Replytried to find a bash v3 compatible way: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82360/5..6 let's see whether that works for everyone… -
core-ci voted on patch set 6 V +1 01/08/24, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51233
-
Stefan Bürk uploaded patch set 7
V +101/09/24, 09:01 -
Stefan Bürk uploaded patch set 8 01/09/24, 09:03
-
core-ci voted on patch set 7 V +1 01/09/24, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51310
-
core-ci voted on patch set 8 V +1 01/09/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51311
-
Benjamin Franzke updated the commit message in patch set 9
V +101/31/24, 07:08 -
Benjamin Franzke commented on patch set 9 CR +1 V +1 01/31/24, 07:09
runTests.sh:561ReplyI think we should take this now, so I removed the WIP flag. -
core-ci voted on patch set 9 V +1 01/31/24, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52534
-
Anja Leichsenring commented on patch set 9 CR +1 V +1 01/31/24, 07:35
nice, this removes the necessitity to have the tested subset as last argument. I like! -
Oliver Klee voted on patch set 9 V +1 01/31/24, 09:24
-
Stefan Bürk voted on patch set 9 CR +2 V +2 01/31/24, 09:31
-
Stefan Bürk merged patch set 10 01/31/24, 10:25
-
Christian Kuhn commented on patch set 10 01/31/24, 10:27
what happens when a sub command overlaps with options from runTest.sh ?
runTests.sh:292