Review main Merged Breaking

82364[!!!][TASK] Harden various methods in PageRepository

Benni Mack CR +2 V +2 Hard +178 −131 updated 01/08/24, 16:12

Commit message

The following methods now have a strict
method signature for all arguments and their return types.

- PageRepository->getPage()
- PageRepository->getPage_noCheck()
- PageRepository->getPageOverlay()
- PageRepository->getPagesOverlay()
- PageRepository->checkRecord()
- PageRepository->getRawRecord()
- PageRepository->enableFields()
- PageRepository->getMultipleGroupsWhereClause()
- PageRepository->versionOL()

Calling one of the methods now require
proper arguments of the respective types.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1421

  1. Benni Mack uploaded patch set 1 01/07/24, 21:01

  2. core-ci voted on patch set 1 V -1 01/07/24, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51190

  3. Benni Mack uploaded patch set 2 V -1 01/08/24, 08:21

  4. core-ci voted on patch set 2 V -1 01/08/24, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51196

  5. Benni Mack uploaded patch set 3 V -1 01/08/24, 08:55

  6. core-ci voted on patch set 3 V +1 01/08/24, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51200

  7. Benni Mack uploaded patch set 4 V +1 01/08/24, 09:09

  8. core-ci voted on patch set 4 V -1 01/08/24, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51202

  9. Benni Mack uploaded patch set 5 V -1 01/08/24, 10:34

  10. core-ci voted on patch set 5 V +1 01/08/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51211

  11. Benni Mack uploaded patch set 6 V +1 01/08/24, 11:01

  12. core-ci voted on patch set 6 V +1 01/08/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51218

  13. Oliver Klee voted on patch set 6 V +1 01/08/24, 14:30

  14. Oli Bartsch commented on patch set 6 CR -1 01/08/24, 14:37

    on it
  15. Oli Bartsch uploaded patch set 7 CR -1 V +1 01/08/24, 15:08

  16. Oli Bartsch voted on patch set 7 CR +1 V +1 01/08/24, 15:08

  17. core-ci voted on patch set 7 V +1 01/08/24, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51253

  18. Oliver Klee voted on patch set 7 V +1 01/08/24, 15:25

  19. Christian Kuhn voted on patch set 7 CR +1 V +1 01/08/24, 16:05

  20. Benni Mack voted on patch set 7 CR +2 V +2 01/08/24, 16:12

  21. Benni Mack merged patch set 8 01/08/24, 16:12