82364[!!!][TASK] Harden various methods in PageRepository
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 14
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+2 −2
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+95 −94
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+0 −3
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php+1 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102775-PageRepositoryMethodsWithNativePHPTypes.rstnew+54 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+9 −9
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+4 −4
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+4 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+4 −4
Review log 1421
-
Benni Mack uploaded patch set 1 01/07/24, 21:01
-
core-ci voted on patch set 1 V -1 01/07/24, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51190
-
Benni Mack uploaded patch set 2
V -101/08/24, 08:21 -
core-ci voted on patch set 2 V -1 01/08/24, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51196
-
Benni Mack uploaded patch set 3
V -101/08/24, 08:55 -
core-ci voted on patch set 3 V +1 01/08/24, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51200
-
Benni Mack uploaded patch set 4
V +101/08/24, 09:09 -
core-ci voted on patch set 4 V -1 01/08/24, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51202
-
Benni Mack uploaded patch set 5
V -101/08/24, 10:34 -
core-ci voted on patch set 5 V +1 01/08/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51211
-
Benni Mack uploaded patch set 6
V +101/08/24, 11:01 -
core-ci voted on patch set 6 V +1 01/08/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51218
-
Oliver Klee voted on patch set 6 V +1 01/08/24, 14:30
-
Oli Bartsch commented on patch set 6 CR -1 01/08/24, 14:37
on it -
Oli Bartsch uploaded patch set 7
CR -1V +101/08/24, 15:08 -
Oli Bartsch voted on patch set 7 CR +1 V +1 01/08/24, 15:08
-
core-ci voted on patch set 7 V +1 01/08/24, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51253
-
Oliver Klee voted on patch set 7 V +1 01/08/24, 15:25
-
Christian Kuhn voted on patch set 7 CR +1 V +1 01/08/24, 16:05
-
Benni Mack voted on patch set 7 CR +2 V +2 01/08/24, 16:12
-
Benni Mack merged patch set 8 01/08/24, 16:12