82365[BUGFIX] Replace example in robots.txt
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1723
-
Lina Wolf uploaded patch set 1 01/08/24, 08:25
-
core-ci voted on patch set 1 V +1 01/08/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51197
-
Chris Müller commented on patch set 1 CR -1 01/08/24, 15:26
I disagree with typo3/ and typo3_src/. They are relevant when using a legacy installation. -
Georg Ringer commented on patch set 1 06/11/24, 17:00
I suggest keeping it but move it to main only -
Georg Ringer updated the commit message in patch set 2
CR -1V +106/19/24, 12:27 -
Georg Ringer voted on patch set 2 CR +1 V +1 06/19/24, 12:27
-
core-ci voted on patch set 2 V -1 06/19/24, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59848
-
core-ci commented on patch set 2 06/20/24, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59848
-
Georg Ringer rebased onto patch set 3
CR +1V +106/20/24, 13:22 -
Lina Wolf commented on patch set 3 06/20/24, 13:24
Reply
Legacy installations are considered out of date with TYPO3 13: https://docs.typo3.org/m/typo3/tutorial-getting-started/main/en-us/Installation/LegacyInstallation.html -
core-ci voted on patch set 3 V +1 06/20/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59919
-
Andreas Kienast commented on patch set 3 06/20/24, 14:30
Reply
"Out of date" is not "unsupported". Don't get me wrong, I'd like to have Composer-based setup only, but that doesn't mean to give incomplete setup / configuration to legacy installations. -
Lina Wolf commented on patch set 3 06/21/24, 05:44
Reply
All this snippet is doing is creating an example robots.txt. It can then be changed to whatever is needed in your project setup. -
Georg Ringer uploaded patch set 4
V +107/27/24, 13:39 -
core-ci voted on patch set 4 V +1 07/27/24, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62298
-
Chris Müller commented on patch set 4 07/31/24, 16:27
site_route.php:57This may be dangerous: 1. People may create the robots.txt this way without reviewing (with wrong domain) 2. Using sitemap.xml as path needs additional routing configuration, the default is ?type=... to get the XML sitemap. So, I suggest to either remove the Sitemap line altogether or comment it out. For the latter the user has to take action to activate it. -
Lina Wolf uploaded patch set 5
V +108/01/24, 05:50 -
Lina Wolf commented on patch set 5 08/01/24, 05:50
site_route.php:57ReplyAcknowledged -
core-ci voted on patch set 5 V +1 08/01/24, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62577
-
Georg Ringer voted on patch set 5 CR +1 V +1 08/01/24, 07:11
-
Garvin Hicking voted on patch set 5 CR +1 V +1 08/01/24, 21:13
-
Christian Kuhn voted on patch set 5 CR +2 V +2 08/06/24, 10:36
-
Christian Kuhn merged patch set 6 08/06/24, 10:36