Review main Merged

82400[TASK] Remove PSR-7 request attribute "target" for backend routes

Benni Mack CR +2 V +2 Easy +2 −4 updated 01/08/24, 16:57

Commit message

Back in TYPO3 v7, the "target" request attribute for BE routes
was added with PSR-7, before Routing with PSR-15 and the
new Module API in TYPO3 v12 was added. It contained
the PHP class and method to be called as Request endpoint.

The Route object which is now used consistently, can now be
used and the target request attribute for backend requests
is removed again.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Benni Mack uploaded patch set 1 01/08/24, 15:01

  2. core-ci voted on patch set 1 V -1 01/08/24, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51252

  3. Benni Mack uploaded patch set 2 V -1 01/08/24, 15:20

  4. Benni Mack uploaded patch set 3 01/08/24, 15:21

  5. core-ci voted on patch set 2 V +1 01/08/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51255

  6. core-ci voted on patch set 3 V +1 01/08/24, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51257

  7. Benni Mack updated the commit message in patch set 4 V +1 01/08/24, 15:30

  8. core-ci voted on patch set 4 V +1 01/08/24, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51258

  9. Oli Bartsch voted on patch set 4 CR +1 V +1 01/08/24, 15:53

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 01/08/24, 16:05

  11. Benjamin Franzke voted on patch set 4 CR +2 V +2 01/08/24, 16:57

  12. Benjamin Franzke merged patch set 5 01/08/24, 16:57