Review main Merged

82401[TASK] Update `core-testing-*` images version

Stefan Bürk CR +2 V +2 Easy +5 −5 updated 01/09/24, 07:41

Commit message

New `core-testing-*` images has been build and released. [1]

This change update used image version to:

* core-testing-nodejs18:1.1.0
* core-testing-nodejs18-chrome:1.1.0
* core-testing-apache24:1.2.0

Additionally, the allowed npm engine in `Build/package.json`
is set accordingly.

[1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/614aa2cc6173a49195a74772fb22fbcf0b3d25f2

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 913

  1. Stefan Bürk uploaded patch set 1 01/08/24, 15:45

  2. core-ci voted on patch set 1 V -1 01/08/24, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51260

  3. Stefan Bürk uploaded patch set 2 V -1 01/08/24, 15:54

  4. Stefan Bürk updated the commit message in patch set 3 01/08/24, 16:01

  5. core-ci voted on patch set 2 V -1 01/08/24, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51263

  6. core-ci voted on patch set 3 V -1 01/08/24, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51266

  7. Stefan Bürk uploaded patch set 4 V -1 01/08/24, 16:09

  8. core-ci voted on patch set 4 V +1 01/08/24, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51267

  9. Benjamin Franzke commented on patch set 4 CR +1 V +1 01/08/24, 16:54

    package.json:12

    Note: We used to lock to a certain npm (earlier yarn) versions here in order to receive stable -lock.json files. since we've got a pinned `lockfile-version` in .npmrc nowadays this change to `>=10.0.0` is fine by me.
  10. Benni Mack voted on patch set 4 CR +1 V +1 01/08/24, 20:09

  11. Andreas Kienast voted on patch set 4 CR +1 V +1 01/09/24, 07:24

  12. Andreas Kienast voted on patch set 4 CR +2 V +2 01/09/24, 07:41

  13. Andreas Kienast merged patch set 5 01/09/24, 07:41