82404[TASK] Consider soft delete in file reference delete method
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/core/Classes/Resource/FileReference.php9+32 −8
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/FileReference/FileReference.csvnew+10 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/FileReference/FileReferenceHardDelete.csvnew+7 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/FileReference/FileReferenceSoftDelete.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/FileReference.csvdeleted+0 −6
- typo3/sysext/core/Tests/Functional/Resource/FileReferenceTest.php+29 −13
Review log 2536
Show 711 earlier messages
-
Torben Hansen uploaded patch set 1 01/08/24, 18:24
-
Torben Hansen updated the commit message in patch set 2 01/08/24, 18:24
-
core-ci voted on patch set 1 V -1 01/08/24, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51278
-
core-ci voted on patch set 2 V -1 01/08/24, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51279
-
Torben Hansen uploaded patch set 3
V -101/08/24, 18:43 -
core-ci voted on patch set 3 V -1 01/08/24, 18:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51280
-
Torben Hansen uploaded patch set 4
V -101/09/24, 06:32 -
core-ci voted on patch set 4 V +1 01/09/24, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51297
-
Mathias Brodala commented on patch set 4 01/09/24, 07:37
-
Torben Hansen uploaded patch set 5
V +101/09/24, 10:09 -
Torben Hansen commented on patch set 4 01/09/24, 10:09
FileReference.php:390ReplyDone
-
core-ci voted on patch set 5 V +1 01/09/24, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51317
-
Oli Bartsch commented on patch set 5 01/09/24, 10:22
Just curios.FileReference.php:384Why do we not just use DataHandler API here? -
Stefan Bürk commented on patch set 5 01/09/24, 10:28
FileReference.php:384ReplyFAL API is also used in FE context, using DataHandler is thereore not possible. -
Mathias Brodala commented on patch set 5 01/09/24, 10:56
FileReference.php:387Since we always use a connection we could retrieve this only once.FileReference.php:391You need to use the configured field from TCA here. -
Torben Hansen uploaded patch set 6
V +101/11/24, 18:28 -
Torben Hansen commented on patch set 5 01/11/24, 18:28
FileReference.php:387ReplyDoneFileReference.php:391ReplyDone -
core-ci voted on patch set 6 V +1 01/11/24, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51457
-
Torben Hansen commented on patch set 6 01/18/24, 18:41
FileReference.php:384ReplyDone -
Torben Hansen uploaded patch set 7
V +102/27/24, 17:39 -
core-ci voted on patch set 7 V -1 02/27/24, 17:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53651
-
Torben Hansen uploaded patch set 8
V -102/27/24, 17:50 -
core-ci voted on patch set 8 V +1 02/27/24, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53654
-
Simon Schaufelberger commented on patch set 8 03/27/24, 09:29
tests -
Torben Hansen updated the commit message in patch set 9
V +103/27/24, 09:30 -
Torben Hansen commented on patch set 9 03/27/24, 09:30
Reply
Done -
core-ci voted on patch set 9 V -1 03/27/24, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54989
-
Torben Hansen rebased onto patch set 10
V -103/27/24, 09:37 -
core-ci voted on patch set 10 V +1 03/27/24, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54990
-
Jörg Bösche voted on patch set 10 CR +1 04/04/24, 06:34
-
Torben Hansen uploaded patch set 11
CR +1V +108/06/24, 08:24 -
core-ci voted on patch set 11 V +1 08/06/24, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62881
-
Christian Kuhn voted on patch set 11 CR +1 V +1 08/06/24, 08:49
-
Stefan Bürk voted on patch set 11 CR +1 V +1 08/06/24, 08:57
-
Christian Kuhn voted on patch set 11 CR +2 V +2 08/06/24, 09:12
-
Christian Kuhn merged patch set 12 08/06/24, 09:12
FileReference.php:390