Review main Merged Breaking

82405[!!!][FEATURE] Migrate enableFields hook to PSR-14 event

Benni Mack CR +2 V +2 Hard +513 −105 updated 01/09/24, 22:04

Commit message

This change replaces the hook to manipulate enableFields
DB query constraints in PageRepository with a PSR-14
Event called "ModifyDefaultConstraintsForDatabaseQueryEvent"
which allows to manipulate existing constraints as well.

At the same time, the method "PageRepository->enableFields"
is deprecated in favor of a new method called "getDefaultConstraints()"
consisting of of two arguments now,
removing the superfluous "show_hidden" which can be
also set via the next method argument "$ignoreArray"
as well.

"getDefaultConstraints()" returns an array of constraints,
which is quite handy to use in your own Doctrine DB
QueryBuilders. This method also supports tableAlias
definitions, useful for JOINs in e.g. Extbase.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 2132

Show 47 earlier messages
  1. Benni Mack uploaded patch set 1 01/08/24, 20:27

  2. core-ci voted on patch set 1 V -1 01/08/24, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51286

  3. Benni Mack uploaded patch set 2 V -1 01/08/24, 20:41

  4. core-ci voted on patch set 2 V -1 01/08/24, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51287

  5. Benni Mack uploaded patch set 3 V -1 01/08/24, 20:54

  6. core-ci voted on patch set 3 V +1 01/08/24, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51288

  7. Benni Mack uploaded patch set 4 V +1 01/09/24, 10:41

  1. core-ci voted on patch set 4 V -1 01/09/24, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51322

  2. Benni Mack uploaded patch set 5 V -1 01/09/24, 11:24

  3. core-ci voted on patch set 5 V +1 01/09/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51325

  4. Benni Mack uploaded patch set 6 V +1 01/09/24, 13:12

  5. core-ci voted on patch set 6 V -1 01/09/24, 13:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51329

  6. Benni Mack uploaded patch set 7 V -1 01/09/24, 13:26

  7. core-ci voted on patch set 7 V -1 01/09/24, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51332

  8. Benni Mack uploaded patch set 8 V -1 01/09/24, 13:36

  9. core-ci voted on patch set 8 V +1 01/09/24, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51333

  10. Christian Kuhn updated the commit message in patch set 9 V +1 01/09/24, 16:02

  11. Christian Kuhn commented on patch set 9 01/09/24, 16:02

    of of
  12. Christian Kuhn commented on patch set 9 CR +1 V +1 01/09/24, 16:02

    lgtm
  13. core-ci voted on patch set 9 V +1 01/09/24, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51343

  14. Oli Bartsch commented on patch set 9 CR -1 01/09/24, 17:21

    on it, will add some tests
  15. Oli Bartsch uploaded patch set 10 CR +1 V +1 01/09/24, 17:29

  16. core-ci voted on patch set 10 V +1 01/09/24, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51347

  17. Oli Bartsch voted on patch set 10 CR +1 V +1 01/09/24, 17:38

  18. Christian Kuhn commented on patch set 10 01/09/24, 18:39

    Deprecation-102793-PageRepositoryEnableFields.rst:43

    please don't make this a top-level headline to not deviate from the casual "Description", "Impact", "Affected installations", "Migration" tuple.
  19. Christian Kuhn voted on patch set 10 CR -1 01/09/24, 18:40

  20. Oli Bartsch uploaded patch set 11 CR +1 V +1 01/09/24, 20:08

  21. Oli Bartsch commented on patch set 11 CR +1 V +1 01/09/24, 20:09

    Deprecation-102793-PageRepositoryEnableFields.rst:43 Reply

    Done
  22. core-ci voted on patch set 11 V +1 01/09/24, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51354

  23. Christian Kuhn voted on patch set 11 CR +1 V +1 01/09/24, 22:04

  24. Benni Mack voted on patch set 11 CR +2 V +2 01/09/24, 22:04

  25. Benni Mack merged patch set 12 01/09/24, 22:04