82411[TASK] Avoid hard-coded table `tt_content` in GridColumnItem
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Daniel Siepmann +1
- Mathias Brodala +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1113
-
Nikita Hovratov uploaded patch set 1 01/09/24, 09:37
-
Mathias Brodala commented on patch set 1 01/09/24, 09:39
-
core-ci voted on patch set 1 V +1 01/09/24, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51314
-
Daniel Siepmann commented on patch set 1 CR +1 01/09/24, 09:48
GridColumnItem.php:244This potentially is not defined for all tables. I would add a check for isset or `?? null` and check whether `$enableCols` is an array afterwards. -
Daniel Siepmann voted on patch set 1 CR 0 01/09/24, 09:48
-
Oli Bartsch uploaded patch set 2
V +101/09/24, 12:45 -
Oli Bartsch commented on patch set 2 CR +1 V +1 01/09/24, 12:46
GridColumn.php:84ReplyDoneGridColumnItem.php:244ReplyDone -
core-ci voted on patch set 2 V +1 01/09/24, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51328
-
Benni Mack voted on patch set 2 CR +1 V +1 01/09/24, 12:59
-
Daniel Siepmann voted on patch set 2 CR +1 01/09/24, 13:00
-
Mathias Brodala voted on patch set 2 CR +1 01/09/24, 13:31
-
Oli Bartsch voted on patch set 2 CR +2 V +2 01/09/24, 13:45
-
Oli Bartsch merged patch set 3 01/09/24, 13:45
GridColumn.php:84