Review main Merged Breaking

82418[!!!][FEATURE] Migrate hooks in PageRepository

Benni Mack CR +2 V +2 Hard +382 −46 updated 01/11/24, 08:50

Commit message

The two leftover hooks
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][\TYPO3\CMS\Core\Domain\PageRepository::class]['init']
and $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_page.php']['getPage']

have been removed.

The former hook is removed without substitution,
as the hook has no benefit anymore in TYPO3 v13:

* There are no public properties to modify after initialization
* `PageRepository` is instantiated multiple times nowadays,
   instead of being a kind-of singleton via TSFE->sys_page

The latter hook is replaced by the more powerful PSR-14
`BeforePageIsRetrievedEvent`, which can not only modify
the UID of the incoming page, but also actually resolve
the whole Page directly and bypassing the actual logic
from PageRepository.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1014

  1. Benni Mack uploaded patch set 1 01/09/24, 22:07

  2. core-ci voted on patch set 1 V -1 01/09/24, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51357

  3. Benni Mack uploaded patch set 2 V -1 01/10/24, 09:25

  4. core-ci voted on patch set 2 V +1 01/10/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51376

  5. Oli Bartsch commented on patch set 2 CR -1 01/10/24, 10:14

    on it
  6. Oli Bartsch uploaded patch set 3 CR -1 V +1 01/10/24, 11:01

  7. core-ci voted on patch set 3 V -1 01/10/24, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51381

  8. Oli Bartsch uploaded patch set 4 V -1 01/10/24, 11:11

  9. core-ci voted on patch set 4 V +1 01/10/24, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51383

  10. Oli Bartsch voted on patch set 4 CR +1 V +1 01/10/24, 11:25

  11. Benni Mack commented on patch set 4 01/10/24, 13:50

    Reply

    Done
  12. Stefan Bürk voted on patch set 4 CR +1 V +1 01/11/24, 08:44

  13. Benni Mack voted on patch set 4 CR +2 V +2 01/11/24, 08:50

  14. Benni Mack merged patch set 5 01/11/24, 08:50