Review main Merged

82421[TASK] Streamline import/export code

Benni Mack CR +2 V +2 Expert +418 −872 updated 01/11/24, 12:11

Commit message

Types are added to all class properties in export
and import classes.

Some code only related to import has been moved
from the parent "god-class" to the relevant subclass.

In addition, some code related to inline images (without FAL)
in RTE images as well as sys_template resources (html, css)
export handling is removed, which did not work since TYPO3 v8
anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1729

Show 24 earlier messages
  1. Benni Mack uploaded patch set 1 01/10/24, 11:04

  2. core-ci voted on patch set 1 V -1 01/10/24, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51382

  3. Benni Mack uploaded patch set 2 V -1 01/10/24, 13:29

  4. core-ci voted on patch set 2 V -1 01/10/24, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51386

  1. Benni Mack uploaded patch set 3 V -1 01/10/24, 14:48

  2. core-ci voted on patch set 3 V -1 01/10/24, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51388

  3. Benni Mack uploaded patch set 4 V -1 01/10/24, 17:05

  4. core-ci voted on patch set 4 V -1 01/10/24, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51393

  5. Benni Mack uploaded patch set 5 V -1 01/10/24, 21:54

  6. Benni Mack uploaded patch set 6 01/10/24, 21:58

  7. core-ci voted on patch set 5 V +1 01/10/24, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51408

  8. Benni Mack uploaded patch set 7 01/10/24, 22:02

  9. core-ci voted on patch set 6 V -1 01/10/24, 22:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51409

  10. Benni Mack uploaded patch set 8 01/10/24, 22:06

  11. core-ci voted on patch set 7 V -1 01/10/24, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51410

  12. core-ci voted on patch set 8 V -1 01/10/24, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51411

  13. Benni Mack uploaded patch set 9 V -1 01/11/24, 06:57

  14. core-ci voted on patch set 9 V +1 01/11/24, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51416

  15. Benni Mack uploaded patch set 10 V +1 01/11/24, 07:56

  16. core-ci voted on patch set 10 V +1 01/11/24, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51417

  17. Benni Mack uploaded patch set 11 V +1 01/11/24, 08:07

  18. core-ci voted on patch set 11 V +1 01/11/24, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51418

  19. Oli Bartsch commented on patch set 11 CR -1 01/11/24, 10:07

    on it
  20. Oli Bartsch uploaded patch set 12 CR -1 V +1 01/11/24, 10:21

  21. core-ci voted on patch set 12 V +1 01/11/24, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51435

  22. Oli Bartsch voted on patch set 12 CR +1 V +1 01/11/24, 10:32

  23. Christian Kuhn voted on patch set 12 CR +1 V +1 01/11/24, 12:01

  24. Benni Mack voted on patch set 12 CR +2 V +2 01/11/24, 12:11

  25. Benni Mack merged patch set 13 01/11/24, 12:11