Review main Merged

82422[BUGFIX] Properly handle unknown link type

Oli Bartsch CR +2 V +2 Easy +33 −11 updated 01/10/24, 18:11

Commit message

In case an invalid link type is used in
a link field, the link browser does no
longer throw an exception but instead
displays a flash message with the
corresponding information.

Additionally, an undefined array key access
is resolved, which might happen e.g. in
case such invalid link is being analyzed
by link validator.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Markus Klein +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Oli Bartsch uploaded patch set 1 01/10/24, 14:26

  2. core-ci voted on patch set 1 V +1 01/10/24, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51387

  3. Benni Mack voted on patch set 1 CR +1 V +1 01/10/24, 15:16

  4. Nikita Hovratov uploaded patch set 2 CR +1 V +1 01/10/24, 16:41

  5. Nikita Hovratov commented on patch set 2 CR +1 V +1 01/10/24, 16:41

    This also happened for links in the RTE. Added the same try catch for this.
  6. core-ci voted on patch set 2 V +1 01/10/24, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51392

  7. Oli Bartsch commented on patch set 2 01/10/24, 17:18

    Reply

    Thanks 👍
  8. Markus Klein voted on patch set 2 CR +1 V +1 01/10/24, 18:02

  9. Nikita Hovratov voted on patch set 2 CR +2 V +2 01/10/24, 18:11

  10. Nikita Hovratov merged patch set 3 01/10/24, 18:11