Review main Merged

82435[TASK] Improve FE title generation

Christian Kuhn CR +2 V +2 Normal +49 −29 updated 01/11/24, 11:05

Commit message

The FE page title handling is a rather awful
construct: First, providers need to be registered
with TypoScript, which is kinda funny in the first
place. Then, single providers are singletons since
extensions may need to park title data when they
are rendered, to be considered later. It also has a
rather ugly 'cache' construct for _INT handling. It
is also questionable that the main class construct
resides in ext:core. And last, getTitle() does not get
*any* information like the current request and thus
needs to fetch stuff from globals.

The patch does not solve all these things, but at least
single providers now retrieve the current request to
work on it instead of fetching stuff from globals. To
be not breaking, the patch does this by adding a
setRequest() method, which is for now not added to the
interface.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 915

  1. Christian Kuhn uploaded patch set 1 01/11/24, 09:21

  2. Christian Kuhn uploaded patch set 2 01/11/24, 09:22

  3. core-ci voted on patch set 2 V +1 01/11/24, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51428

  4. Christian Kuhn updated the commit message in patch set 3 V +1 01/11/24, 09:31

  5. core-ci voted on patch set 1 V -1 01/11/24, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51426

  6. Christian Kuhn updated the commit message in patch set 4 01/11/24, 09:36

  7. core-ci voted on patch set 3 V +1 01/11/24, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51430

  8. Christian Kuhn updated the commit message in patch set 5 01/11/24, 09:37

  9. Christian Kuhn updated the commit message in patch set 6 01/11/24, 09:39

  10. core-ci voted on patch set 4 V +1 01/11/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51432

  11. core-ci voted on patch set 5 V +1 01/11/24, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51433

  12. core-ci voted on patch set 6 V +1 01/11/24, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51434

  13. Benni Mack voted on patch set 6 CR +1 V +1 01/11/24, 10:29

  14. Oli Bartsch voted on patch set 6 CR +2 V +2 01/11/24, 11:05

  15. Oli Bartsch merged patch set 7 01/11/24, 11:05