Review main Merged

82436[TASK] Simplify extbase CacheService

Christian Kuhn CR +2 V +2 Normal +36 −65 updated 01/11/24, 12:13

Commit message

Extbase CacheService has been extracted from the storage
backend in v11 with #94703, is still @internal and still
only used by the storage backend (fired in extbase bootstrap).

It has a weird construct that checks if a given table/uid
combination has a pid column. With this service being fired
from storage backends, which hard codes various pid calls
already, and with extbase repositories working on TCA tables
that have a pid column anyway, this is useless.

Additionally, there is code that checks if TSFE exists to
eventually clear page cache of current page uid. This is bogus
as well: Extbase is fired either as USER or USER_INT plugin.
In case of USER, a page cache entry can't exist, or the plugin
would not be rendered anyways. In case of USER_INT, the plugin
content is not cached, so it does not make sense to kill any
page cache entry.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 01/11/24, 11:48

  2. Benni Mack voted on patch set 1 CR +1 V +1 01/11/24, 11:53

  3. core-ci voted on patch set 1 V +1 01/11/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51439

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 01/11/24, 12:08

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 01/11/24, 12:13

  6. Christian Kuhn merged patch set 2 01/11/24, 12:13