Review main Merged

82440[BUGFIX] Translate Content Type labels if retrieved from fallback

Nikita Hovratov CR +2 V +2 Easy +18 −6 updated 07/13/24, 06:48

Commit message

This may happen if the CType is not defined via TCA but rather through
page TSConfig or itemsProcFunc.

This is really an edge-case, which was found during experiments on
backend previews for something else than tt_content records. Still, the
above scenario may theoretically happen and can easily be reproduced.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Nikita Hovratov uploaded patch set 1 01/11/24, 21:46

  2. core-ci voted on patch set 1 V +1 01/11/24, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51461

  3. Simon Schaufelberger commented on patch set 1 07/12/24, 00:18

    Is this still relevant and if so, can you please rebase?
  4. Nikita Hovratov uploaded patch set 2 V +1 07/12/24, 07:43

  5. Nikita Hovratov commented on patch set 2 07/12/24, 07:46

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 07/12/24, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61458

  7. Georg Ringer voted on patch set 2 CR +1 V +1 07/12/24, 17:20

  8. Benni Mack voted on patch set 2 CR +1 V +1 07/12/24, 19:33

  9. Nikita Hovratov voted on patch set 2 CR +2 V +2 07/13/24, 06:36

  10. Nikita Hovratov merged patch set 3 07/13/24, 06:48