82442[TASK] Reduce hard-coded `tt_content` table in StandardPreviewRenderer
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 2
Review log 3448
Show 1623 earlier messages
-
Nikita Hovratov uploaded patch set 1 01/11/24, 23:03
-
core-ci voted on patch set 1 V +1 01/11/24, 23:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51470
-
Oli Bartsch uploaded patch set 2
V +101/12/24, 09:15 -
core-ci voted on patch set 2 V +1 01/12/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51488
-
Oli Bartsch voted on patch set 2 CR +1 V +1 01/12/24, 09:21
-
Benni Mack commented on patch set 2 01/12/24, 09:29
-
Nikita Hovratov commented on patch set 2 01/12/24, 09:38
GridColumnItem.php:356ReplyWhat do you mean? The type column would still be CType. Sub types are not relevant here. -
Daniel Siepmann commented on patch set 2 01/18/24, 09:30
StandardContentPreviewRenderer.php:83This field might not exist on other tables as tt_content. Same for others like header_layout, subheader. Is that planned for a follow up patch?StandardContentPreviewRenderer.php:118Not sure if we should guard that switch with a check for $table === 'tt_content'. Otherwise it might jump in of some custom record table has matching types and "things" will happen.StandardContentPreviewRenderer.php:199This will result in issues with tables not providing these fields. E.g. space_before_class is very special to tt_content. starttime, endtime and fe_group could be fetched from TCA.ctrl.enablecolumns to ensure we only fetch existing columns. That also ensurs we use the configured database table columns, as they can be configured and don't need to be named that way. -
Oli Bartsch commented on patch set 2 01/18/24, 10:39
GridColumnItem.php:359I think we should name this `getRecordType()` -
Oli Bartsch voted on patch set 2 CR 0 V 0 01/18/24, 10:39
-
Nikita Hovratov uploaded patch set 3
V +101/23/24, 19:05 -
core-ci voted on patch set 3 V -1 01/23/24, 19:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52031
-
Nikita Hovratov uploaded patch set 4
V -101/23/24, 19:48 -
core-ci voted on patch set 4 V +1 01/23/24, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52033
-
Nikita Hovratov uploaded patch set 5
V +101/23/24, 20:06 -
Nikita Hovratov commented on patch set 4 01/23/24, 20:07
StandardContentPreviewRenderer.php:83ReplyDoneStandardContentPreviewRenderer.php:118ReplyDoneStandardContentPreviewRenderer.php:199ReplyDoneGridColumnItem.php:356ReplyI'll mark this as done. Custom list_type previews are dealt in StandardContentPreviewRenderer->renderContentElementPreviewFromFluidTemplateGridColumnItem.php:359ReplyI would like to keep it `getContentType`. Here is why: - we already have a method called `getContentTypeLabel` there. - I think of Content Type == Record Type interchangeably. Are you ok with that? -
core-ci voted on patch set 5 V +1 01/23/24, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52036
-
Nikita Hovratov uploaded patch set 6
V +101/23/24, 20:16 -
Nikita Hovratov uploaded patch set 7 01/23/24, 20:17
-
core-ci voted on patch set 6 V +1 01/23/24, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52038
-
core-ci voted on patch set 7 V +1 01/23/24, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52040
-
Nikita Hovratov uploaded patch set 8
V +101/23/24, 21:02 -
Nikita Hovratov uploaded patch set 9 01/23/24, 21:08
-
core-ci voted on patch set 8 V +1 01/23/24, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52048
-
core-ci voted on patch set 9 V +1 01/23/24, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52049
-
Benni Mack commented on patch set 9 01/23/24, 22:11
Just a side node while reviewing: I hope we can split out the StandardContentPreviewRenderer, by e.g. moving all menu_* related Ctypes in their own PreviewRenderers. -
Daniel Siepmann commented on patch set 9 01/24/24, 06:46
StandardContentPreviewRenderer.php:295Why is the 2nd argument optional? I guess this is done for backwards compatibility if developers extend this class? Than it's fine for me. Otherwise: this method is protected and not public API and we pass the argument. So we could make this argument required? -
Nikita Hovratov commented on patch set 9 01/24/24, 07:55
StandardContentPreviewRenderer.php:295ReplyYes, exactly. I don't want to deliberately break extensions in v12, namely Gridelements: https://github.com/CodersCare/gridelements/blob/e16b95c713665602b75a131805524ce76fc1c1ad/Classes/PageLayoutView/GridelementsPreviewRenderer.php#L143 In v13, we can happily change this to GridColumnItem to be the only parameter. -
Daniel Siepmann commented on patch set 9 CR +1 01/24/24, 07:56
StandardContentPreviewRenderer.php:295ReplyAcknowledged -
Oli Bartsch commented on patch set 9 01/24/24, 13:04
GridColumnItem.php:359ReplyActually we are only talking about "content type" in context of `tt_content`, which is exactly what this patch tries to soften in this class. I think "recordType" is more generell and describes exactly what is returned here. -
Nikita Hovratov commented on patch set 9 01/24/24, 13:26
GridColumnItem.php:359ReplyThis is not set in stone. Actually everything is content one way or another. In Content Blocks we introduced the definition of Content Types as a generic name for Content Element (Types), Page Types and generic Record Types. I would like to streamline this and not introduce new, contradicting naming. -
Oli Bartsch commented on patch set 9 01/24/24, 13:31
GridColumnItem.php:359ReplyIt's at least already named this way in the docs, see e.g. https://docs.typo3.org/m/typo3/reference-tca/main/en-us/Ctrl/Properties/Type.html#type -
Nikita Hovratov uploaded patch set 10
CR +1V +101/24/24, 16:31 -
core-ci voted on patch set 10 V +1 01/24/24, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52101
-
Nikita Hovratov commented on patch set 10 01/24/24, 16:45
GridColumnItem.php:359ReplyFine. Then let's align with what is currently used in Core and documentation. When Content Blocks comes, we can still rename things (also in Content Blocks itself), if necessary. -
Nikita Hovratov uploaded patch set 11
V +102/17/24, 16:32 -
core-ci voted on patch set 11 V +1 02/17/24, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53291
-
Nikita Hovratov uploaded patch set 12
V +102/17/24, 17:05 -
Nikita Hovratov uploaded patch set 13 02/17/24, 17:06
-
core-ci voted on patch set 12 V +1 02/17/24, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53293
-
core-ci voted on patch set 13 V +1 02/17/24, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53294
-
Jörg Bösche voted on patch set 13 CR +1 02/27/24, 08:15
-
Oli Bartsch uploaded patch set 14
CR +1V +106/13/24, 18:35 -
core-ci voted on patch set 14 V +1 06/13/24, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59533
-
Oli Bartsch voted on patch set 14 CR +1 V +1 06/13/24, 18:49
-
Georg Ringer voted on patch set 14 CR +1 V +1 06/13/24, 18:51
-
Oli Bartsch voted on patch set 14 CR +2 V +2 06/13/24, 19:03
-
Oli Bartsch merged patch set 15 06/13/24, 19:06
GridColumnItem.php:356