Review main Merged

82445[BUGFIX] Use DataHandler->log consistently

Benni Mack CR +2 V +2 Easy +7 −28 updated 01/12/24, 12:55

Commit message

When using DataHandler->log, the format changed
to using an associative array as $data, whereas
the message then contains PSR-3 compatible log
strings.

This was handled in TYPO3 v12 but a few
places around Workspaces were missed.

This patch adapts these places.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1013

  1. Benni Mack uploaded patch set 1 01/12/24, 09:09

  2. core-ci voted on patch set 1 V +1 01/12/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51486

  3. Oli Bartsch commented on patch set 1 01/12/24, 09:41

    Issue id missing
  4. Benni Mack updated the commit message in patch set 2 V +1 01/12/24, 10:02

  5. Benni Mack commented on patch set 2 01/12/24, 10:02

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 01/12/24, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51489

  7. Christian Kuhn commented on patch set 2 01/12/24, 10:53

    DataHandlerHook.php:732

    please remove these 2 now unused labels from .xlf
  8. Benni Mack uploaded patch set 3 V +1 01/12/24, 11:21

  9. Oli Bartsch commented on patch set 3 CR +1 V +1 01/12/24, 11:24

    DataHandlerHook.php:732 Reply

    Done
  10. core-ci voted on patch set 3 V +1 01/12/24, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51494

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 01/12/24, 11:55

  12. Benni Mack voted on patch set 3 CR +2 V +2 01/12/24, 12:55

  13. Benni Mack merged patch set 4 01/12/24, 12:55