Review 12.4 Merged

82449[BUGFIX] Update doctrine/dbal to ensure performance bugfix

Stefan Bürk CR +2 V +2 Easy +5 −5 updated 01/12/24, 21:34

Commit message

Doctrine DBAL 3.7.0 introduced a performance issue [1]
which has been already fixed by the Doctrine Team [2].

This change updates the `doctrine/dbal` composer constraint
to ensure that this performance issue is gone.

Note:   The monorepo composer.lock already containted the
        3.7.2 bugfis release, therefore this has not been
        detected in casual core development. This update
        is to mitigate the performance issue at all costs
        for TYPO3 users.

As a sideeffect, this should put `composerInstallMin`
nightly function tests on speed again.

Used command(s):

> composer require --no-update --no-install \
    -d typo3/sysext/redirects \
    "doctrine/dbal":"^3.7.2" ; \
  composer require --no-update --no-install \
    -d typo3/sysext/core \
    "doctrine/dbal":"^3.7.2" ; \
  composer require --no-update --no-install \
    -d typo3/sysext/install \
    "doctrine/dbal":"^3.7.2" ; \
  composer require --no-update \
    "doctrine/dbal":"^3.7.2" ; \
  composer update --lock

[1] https://github.com/contao/contao/issues/6409
[2] https://github.com/doctrine/dbal/pull/6202

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 78

  1. Stefan Bürk uploaded patch set 1 01/12/24, 18:49

  2. Oliver Klee voted on patch set 1 CR +1 01/12/24, 18:52

  3. core-ci voted on patch set 1 V +1 01/12/24, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51514

  4. Oliver Klee voted on patch set 1 V +1 01/12/24, 19:20

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 01/12/24, 19:51

  6. Benni Mack voted on patch set 1 CR +1 V +1 01/12/24, 20:53

  7. Stefan Bürk voted on patch set 1 CR +2 V +2 01/12/24, 21:34

  8. Stefan Bürk merged patch set 2 01/12/24, 21:34