Review main Abandoned

82463[BUGFIX] Fix incorrect fallback for list_type plugin itemGroups

Nikita Hovratov CR 0 V 0 Easy +6 −2 updated 01/15/24, 21:33

Commit message

A recent patch has introduced an enhancement, which allows to use
itemGroups from CType for plugins of type list_type. However, the
fallback to an empty array is wrong and leads to a PHP type conversion
error. This patch adds a check whether the itemGroup exists at all and
only then adds it to list_type.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 23

  1. Nikita Hovratov uploaded patch set 1 01/15/24, 21:24

  2. core-ci voted on patch set 1 V +1 01/15/24, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51610

  3. Nikita Hovratov abandoned the change 01/15/24, 21:33