Review main Merged

82503[TASK] Update to CKEditor5 v41

Benjamin Franzke CR +2 V +2 Nightmare +1919 −1526 updated 01/20/24, 21:55

Commit message

Also switch back to `List` instead of `DocumentList`, since the new
DocumentList implementation (that we use since #100348) has been
integrated into `List` and the temporary name `DocumentList` is now
deprecated (and just a no-op wrapper for `List`).

Executed commands:
   npm install -P $(
     grep ckeditor5 package.json | \
     grep '\^40' | \
     grep -v dev-utils | \
     sed 's/^[^"]*"\([^"]*\)".*/\1@^41/' \
   )
   npm remove @ckeditor/ckeditor5-dev-utils
   npm install -D @ckeditor/ckeditor5-dev-utils@^39.5.1
   npm run build

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 105

Show 85 more files

Review log 911

  1. Benjamin Franzke uploaded patch set 1 01/18/24, 09:38

  2. core-ci voted on patch set 1 V +1 01/18/24, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51733

  3. Andreas Kienast voted on patch set 1 CR +1 01/18/24, 10:31

  4. Benni Mack commented on patch set 1 01/18/24, 10:58

    ckeditor5.rollup.config.js:77

    Please correct the wording: Please check and "allowlist" in ...
  5. Benjamin Franzke uploaded patch set 2 CR +1 V +1 01/18/24, 11:05

  6. Benjamin Franzke commented on patch set 2 01/18/24, 11:05

    ckeditor5.rollup.config.js:77 Reply

    Done
  7. core-ci voted on patch set 2 V +1 01/18/24, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51742

  8. Andreas Kienast voted on patch set 2 CR +1 01/18/24, 13:38

  9. Andreas Kienast voted on patch set 2 V +1 01/19/24, 07:41

  10. Benni Mack voted on patch set 2 CR +2 V +2 01/20/24, 21:55

  11. Benni Mack merged patch set 3 01/20/24, 21:55