Review main Merged

82508[TASK] Mitigate `AbstractPlatform::getIdentifierQuoteCharacter()` usage

Stefan Bürk CR +2 V +2 Normal +181 −7 updated 01/18/24, 18:30

Commit message

`AbstractPlatform::getIdentifierQuoteCharacter()`
is deprecated since Doctrine DBAL 3.7.x and will
be removed with Doctrine DBAL 4.x - with proposing
to use `AbstractPlatform::quoteIdentifier()` to
retrieve it. [1][2]

The proposed way to mitigate this depraction looks like

 $quoteChar = (new AbstractPlatform)
   ->quoteSingleIdentifier('fake')[0];

which is now capsulated into a new internal `PlatformHelper`
class and usages is therefore modified towards this helper.

Using a dedicated helper for it ensures that eventually future
specific modification can take place at one place and prohibit
missing usage places later-on. Additionally, test guarding can
be ensured on the helper class.

[1] https://github.com/doctrine/dbal/blob/3.7.x/UPGRADE.md#deprecated-abstractplatform-methods-exposing-quote-characters
[2] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-removed-abstractplatform-methods-exposing-quote-characters

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1115

  1. Stefan Bürk uploaded patch set 1 01/18/24, 11:38

  2. Stefan Bürk wrote 01/18/24, 11:39

    Topic set to doctrine-dbal
  3. Stefan Bürk updated the commit message in patch set 2 01/18/24, 11:40

  4. core-ci voted on patch set 1 V +1 01/18/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51745

  5. core-ci voted on patch set 2 V +1 01/18/24, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51746

  6. Stefan Bürk updated the commit message in patch set 3 V +1 01/18/24, 14:41

  7. core-ci voted on patch set 3 V +1 01/18/24, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51760

  8. Oliver Klee voted on patch set 3 V +1 01/18/24, 14:57

  9. Oliver Klee voted on patch set 3 CR +1 01/18/24, 14:58

  10. Christian Kuhn updated the commit message in patch set 4 CR +1 V +1 01/18/24, 17:44

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 01/18/24, 17:45

  12. core-ci voted on patch set 4 V +1 01/18/24, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51780

  13. Garvin Hicking voted on patch set 4 CR +1 V +1 01/18/24, 18:18

  14. Stefan Bürk voted on patch set 4 CR +2 V +2 01/18/24, 18:30

  15. Stefan Bürk merged patch set 5 01/18/24, 18:30