Review main Merged

82509[TASK] Remove unused labels from core locallang_tca.xlf file

Marcin Sągol CR +2 V +2 Easy +0 −6 updated 01/18/24, 17:49

Commit message

Current workspace settings for a backend user or group allow only
to set editing in the Live workspace. The translation file though contains labels for other workspace-related options that no longer exist. So those labels are removed now:

- workspace_perms_draft
- workspace_perms_custom

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Marcin Sągol uploaded patch set 1 01/18/24, 11:58

  2. core-ci voted on patch set 1 V +1 01/18/24, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51747

  3. Oli Bartsch commented on patch set 1 CR -1 01/18/24, 13:09

    We usually do not remove any label in LTS versions. Please remove 12.4 from the Releases line.
  4. Marcin Sągol uploaded patch set 2 CR -1 V +1 01/18/24, 13:14

  5. core-ci voted on patch set 2 V +1 01/18/24, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51756

  6. Oli Bartsch updated the commit message in patch set 3 V +1 01/18/24, 15:35

  7. Oli Bartsch voted on patch set 3 CR +1 V +1 01/18/24, 15:35

  8. core-ci voted on patch set 3 V +1 01/18/24, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51768

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 01/18/24, 17:49

  10. Christian Kuhn merged patch set 4 01/18/24, 17:49