Review main Merged

82511[TASK] Doctrine DBAL 3.2 Connection::lastInsertId() mitigation

Stefan Bürk CR +2 V +2 Normal +56 −37 updated 01/18/24, 18:42

Commit message

The usage of `Connection::lastInsertId()` with a sequence name
is deprecated as unsafe in scenarios with multiple concurrent
connections since Doctrine DBAL 3.2. If a newly inserted row
needs to be referenced, it is recommended to generate its
identifier explicitly prior to insertion.

This change adjusts the usages to avoid calling the method with
the `$name` and/or the TYPO3 additional `$fieldName` argument.

The method signature is not adjusted yet, due to the bounding
to the extended connection method signature.

[1] https://github.com/doctrine/dbal/blob/3.8.x/UPGRADE.md#deprecated-connectionlastinsertidname

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 27

Show 7 more files