Review main Merged

82515[TASK] Pass connection to ConnectionMigrator and factory method

Stefan Bürk CR +2 V +2 Normal +19 −41 updated 01/20/24, 15:04

Commit message

Only the connection name has been passed to the `ConnectionMigrator`
and factory method `ConnectionMigrator::create()` and the connection
retrieved using `GeneralUtility::makeInstance(ConnectionPool::class)`.

This change modifies the constructor and factory method to hand over
the connection along with current arguments and adjusts usages and
tests.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1623

  1. Stefan Bürk uploaded patch set 1 01/18/24, 17:22

  2. Stefan Bürk updated the commit message in patch set 2 01/18/24, 17:23

  3. core-ci voted on patch set 2 V +1 01/18/24, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51776

  4. core-ci commented on patch set 2 01/18/24, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51778

  5. Stefan Bürk updated the commit message in patch set 3 V +1 01/18/24, 20:00

  6. Stefan Bürk rebased onto patch set 4 01/18/24, 20:00

  7. core-ci voted on patch set 3 V +1 01/18/24, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51783

  8. Garvin Hicking updated the commit message in patch set 5 01/18/24, 20:07

  9. core-ci voted on patch set 4 V +1 01/18/24, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51784

  10. Garvin Hicking voted on patch set 5 CR +1 V +1 01/18/24, 20:10

  11. core-ci voted on patch set 5 V +1 01/18/24, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51785

  12. Oliver Klee voted on patch set 5 V +1 01/18/24, 22:05

  13. Oliver Klee voted on patch set 5 CR +1 01/18/24, 22:06

  14. Stefan Bürk rebased onto patch set 6 CR +1 V +1 01/19/24, 09:38

  15. Garvin Hicking voted on patch set 6 CR +1 V +1 01/19/24, 09:39

  16. core-ci voted on patch set 6 V +1 01/19/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51792

  17. Stefan Bürk rebased onto patch set 7 CR +1 V +1 01/19/24, 17:24

  18. core-ci voted on patch set 7 V +1 01/19/24, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51824

  19. Oliver Klee voted on patch set 7 CR +1 V +1 01/19/24, 17:41

  20. Garvin Hicking voted on patch set 7 CR +1 V +1 01/19/24, 18:10

  21. Benni Mack voted on patch set 7 CR +1 V +1 01/19/24, 20:05

  22. Stefan Bürk voted on patch set 7 CR +2 V +2 01/20/24, 15:04

  23. Stefan Bürk merged patch set 8 01/20/24, 15:04